Add support for Empty Graphs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this set, we see incorrect rendering in Safari and Chrome.
yugesk
reviewed
Oct 2, 2023
| @@ -42,16 +42,14 @@ function getStatValues(run, elem, key, run_data) { | |||
| } | |||
|
|
|||
| function getStatKeys(run, container_id, mb, keys, run_data) { | |||
| var data = keys; | |||
| data.forEach(function (value, index, arr) { | |||
| for (let i = 0; i < all_run_keys.length; i++) { | |||
There was a problem hiding this comment.
where is all_run_keys coming from?
There was a problem hiding this comment.
It is found it src/html_files/utils.ts.
There was a problem hiding this comment.
is keys being used here? why not get all_run_keys as function parameter?
There was a problem hiding this comment.
Keys is used below. all_run_keys is global. We don't have to get as a function parameter.
yugesk
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing runs, if a key is not present for a particular run the graphs get misaligned. Prevent this by using empty graphs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
emptytest.tar.gz