Hide zero, N/A graphs across runs #84
Conversation
|
What about the option for interrupts? |
We can't say if interrupt nr 1 for a system is the same as interrupt nr 1 for another system. |
src/html_files/index.html
Outdated
| @@ -42,34 +42,54 @@ | |||
| <div id="perfstat-runs"></div> | |||
| </div> | |||
| <div id="meminfo" class="tabcontent"> | |||
| <div> | |||
| <h3>Hide zero, N/A graphs:</h3> | |||
There was a problem hiding this comment.
I think some different wording like "Hide N/A and all-zeros graphs" would be better. "Hide empty graphs" would be on the other end where it's really simple at the cost of accuracy (somewhat).
src/html_files/index.ts
Outdated
| var elems = document.getElementsByClassName('vmstat-button'); | ||
| for (var i=0; i < elems.length; i++) { | ||
| elems[i].addEventListener("click",function(evn: Event) { | ||
| if (this.id == "vmstat_hide_yes"){ | ||
| vmStat(true); | ||
| } else { | ||
| vmStat(false); | ||
| } | ||
| }) | ||
| } | ||
| var elems = document.getElementsByClassName('diskstat-button'); | ||
| for (var i=0; i < elems.length; i++) { | ||
| elems[i].addEventListener("click",function(evn: Event) { | ||
| if (this.id == "diskstat_hide_yes"){ | ||
| diskStats(true); | ||
| } else { | ||
| diskStats(false); | ||
| } | ||
| }) | ||
| } | ||
| var elems = document.getElementsByClassName('meminfo-button'); | ||
| for (var i=0; i < elems.length; i++) { | ||
| elems[i].addEventListener("click",function(evn: Event) { | ||
| if (this.id == "meminfo_hide_yes"){ | ||
| meminfo(true); | ||
| } else { | ||
| meminfo(false); | ||
| } | ||
| }) | ||
| } | ||
| var elems = document.getElementsByClassName('netstat-button'); | ||
| for (var i=0; i < elems.length; i++) { | ||
| elems[i].addEventListener("click",function(evn: Event) { | ||
| if (this.id == "netstat_hide_yes"){ | ||
| netStat(true); | ||
| } else { | ||
| netStat(false); | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
There's gotta be a way to turn this into a single loop over a set of tuples :p
It will be a lot less error-prone if something has to change later
There was a problem hiding this comment.
Yeah. I've refactored index.ts.
| @@ -1,11 +1,11 @@ | |||
| let got_kernel_config_data = false; | |||
| let current_diff_status = false; | |||
| let current_kernel_diff_status = false; | |||
There was a problem hiding this comment.
What are these changes? Certainly nothing to do with hiding zero graphs.
There was a problem hiding this comment.
The Kernel Config and Sysctl used to default to 'No' for Diff. Based on that, the code was setup to calculate the keys for when the user presses 'Yes' for diff. We are now going to default to 'Yes' for Diff and the code now accounts for that.
| @@ -5,78 +5,83 @@ var sysctl_runs: Map<string, RunEntry> = new Map<string, RunEntry>(); | |||
| var sysctl_run_names: Array<string> = []; | |||
| var sysctl_common_keys: Array<string> = []; | |||
|
|
|||
| function getSysctl(run, container_id, run_data) { | |||
There was a problem hiding this comment.
Also not related to hiding zero graphs
| <input type="radio" class="sysctl-button" id="sysctl_diff_no" name="sysctlDiff">No</button> | ||
| </div> | ||
| <div id="sysctl-data-runs"></div> | ||
| </div> | ||
| <div id="vmstat" class="tabcontent"> | ||
| <div> | ||
| <h3>Hide zero, N/A graphs:</h3> | ||
| <input type="radio" class="vmstat-button" id="vmstat_hide_yes" name="vmstatHide" checked>Yes</button> |
There was a problem hiding this comment.
vmStatHide is not a very good name for what this does
There was a problem hiding this comment.
'Hide zero' under 'vmstat' tab = 'vmStatHide'.
There was a problem hiding this comment.
Until you add the ability to hide something else and then have to rename this ;)
Make Diff 'Yes' the default for Kernel Config and Sysctl.
Suggestions? |
If you're going to have some sort of parameterization of the pages, then firstly it ideally wouldn't exist at the top-level index.ts. Failing that, you have to find some other naming that works for the two current use cases: diff vs non-diff (neither of which is hiding anything), and whether to hide all-zeros graphs (in which case hide is too vague and doomed to have to be renamed once we had the option to hide something else). Also, what's going to happen once a page has more that one boolean parameter (or non-boolean)? |
By default, don't show graphs for keys where the entries are all zero and N/A across all runs. There is a radio button on the top to see zero, N/A graphs if so needed.
Tabs updated: vmstat, diskstat, netstat, pmu stat, kernel config and sysctl.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
hidetest.tar.gz