Fix rustfmt, clippy issues #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janaknat
force-pushed
the
fmt-clippy
branch
2 times, most recently
from
b71d09e to
453035d
Compare
Also, add rustfmt and clippy to Github CI.
action-rs has been archived. Move to using dtolnay/rust-toolchain.
wash-amzn
reviewed
Nov 7, 2023
.github/workflows/ci.yml
Outdated
| @@ -21,11 +21,9 @@ jobs: | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v3 | |||
| - name: Install Rust toolchain | |||
| uses: actions-rs/toolchain@v1 | |||
| uses: dtolnay/rust-toolchain@stable | |||
There was a problem hiding this comment.
Leaving this version floating means we could get spontaneous failures starting at any point not triggered by a change :/
There was a problem hiding this comment.
I think this should be locked to a version, assuming that's possible.
Comment on lines
+72
to
+75
| - name: Run clippy | ||
| run: source ~/.nvm/nvm.sh && cargo clippy --all-targets --all-features | ||
| - name: Run rustfmt | ||
| run: source ~/.nvm/nvm.sh && cargo fmt --all -- --check |
There was a problem hiding this comment.
You shouldn't need the nvm.sh part for clippy and format runs, only for things that do a build. Do a clean and then try them without that part.
There was a problem hiding this comment.
It failed without the nvm.sh. I initially tried without it and all CI jobs failed.
| let status = Command::new("npm") | ||
| .arg("install") | ||
| .spawn()? | ||
| .wait()?; | ||
| if ! status.success() { | ||
| let status = Command::new("npm").arg("install").spawn()?.wait()?; |
There was a problem hiding this comment.
This is the kind of thing that's th downside to auto-formatting. This is worse formatting.
wash-amzn
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add Github checks for rustfmt and clippy.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.