test: Update container helper to create proxies #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
toxiproxy
branch
2 times, most recently
from
94abea0
to
8c414f8
Compare
karenc-bq
requested review from
sergiyvamz,
brunos-bq,
crystall-bitquill and
aaronchung-bitquill
sergiyvamz
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ToxiproxyContainer used to handle the creation of the Toxiproxy client and the proxies. This was recently deprecated and user applications are encouraged to create their own client.
This PR updates the container helper to create and handle the toxiproxy client for each proxy container instead of relying on the
getProxymethod.Description
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.