Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging field to virtual-node #45

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Conversation

kiranmeduri
Copy link
Collaborator

Issue #, if available:
#43

Description of changes:
Adding logging field to virtual-node to match https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_VirtualNodeSpec.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, matches the AppMesh documentation. Thanks for adding tests.

pkg/aws/appmesh.go Outdated Show resolved Hide resolved
pkg/aws/appmesh.go Outdated Show resolved Hide resolved
pkg/controller/virtualnode.go Show resolved Hide resolved
Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

Copy link
Contributor

@nckturner nckturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -15,11 +15,17 @@ if [[ -z "${AWS_REGION}" ]]; then
exit 1
fi

DIR=$(cd "$(dirname "$0")"; pwd)/..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated above

@mogren mogren merged commit 0372e2c into aws:master Jun 27, 2019
@kiranmeduri kiranmeduri deleted the logging branch June 27, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants