-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logging field to virtual-node #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, matches the AppMesh documentation. Thanks for adding tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -15,11 +15,17 @@ if [[ -z "${AWS_REGION}" ]]; then | |||
exit 1 | |||
fi | |||
|
|||
DIR=$(cd "$(dirname "$0")"; pwd)/.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated above
Issue #, if available:
#43
Description of changes:
Adding logging field to virtual-node to match https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_VirtualNodeSpec.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.