Added TCP route support #46
Conversation
| spec: | ||
| containers: | ||
| - name: tcpecho | ||
| image: cjimti/go-echo |
| protocol: tcp | ||
| routes: | ||
| - name: tcpecho-route | ||
| tcp: |
There was a problem hiding this comment.
nope, AppMesh API will throw error.
| apiVersion: appmesh.k8s.aws/v1beta1 | ||
| kind: VirtualNode | ||
| metadata: | ||
| name: tcpecho |
There was a problem hiding this comment.
Long term, I think we should have multiple examples that each show off a subset of related features. This will help users determine what configuration is necessary for each feature. I think tcpecho is a good candidate for the first stand-alone example, what do you think?
There was a problem hiding this comment.
I believe examples should go to https://github.com/aws/aws-app-mesh-examples under walkthroughs.
There was a problem hiding this comment.
That makes sense. I'll create an issue. We can leave it as one example for now, then.
There was a problem hiding this comment.
Can you add tcp routes to the virtualservice definition? https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/deploy/virtual-service-definition.yaml#L39
|
Added tcp to virtual-service CRD spec. Please take a look. Thanks |
Issue #, if available:
#42
Description of changes:
Add TCP route support to match https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_RouteSpec.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.