-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Envoy image version to v1.24.0.0-prod #657
Conversation
I believe the makefile should be updated as well - |
Checked with @paulyeo21 offline, looks like that version indicates the beginning of the agent feature waitUntilProxyReady, hence should not be updated. |
Better to rename that variable & add comments to avoid confusion. |
Hrm, yeah I think we might need to think through this policy a bit more then. The integration tests as-is will call |
Yeah, having thought about this a bit more, I'm pretty sure we should increment that variable. There are still ways to test older versions by setting that variable (i.e. I think there's a separate value check w/in the sidecar builder that's necessary for |
Synced with @rakeb, I think I was wrong about the Makefile. The Makefile is only related to the Integ test. We need to include the version update. Updated the PR. |
Issue #, if available:
Description of changes:
Bump AppMesh Envoy image version from v1.22.2.1-prod to v1.24.0.0-prod .
Ref: #621
Envoy v1.24.0 release notes: https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.24/v1.24.0
Note: please monitor this aws/aws-app-mesh-roadmap#442 and make sure the v1.24.0.0 Envoy image is available in public ECR before merging this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.