Preserve grpc port value from crd #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysdongAmazon
approved these changes
Jun 27, 2023
joesbigidea
reviewed
Jun 27, 2023
| @@ -333,8 +333,8 @@ func Convert_CRD_GRPCRouteMatch_To_SDK_GrpcRouteMatch(crdObj *appmesh.GRPCRouteM | |||
| sdkObj.Metadata = sdkMetadataList | |||
| sdkObj.MethodName = crdObj.MethodName | |||
| sdkObj.ServiceName = crdObj.ServiceName | |||
| sdkObj.Port = crdObj.Port | |||
There was a problem hiding this comment.
Can we get tests on this behavior?
There was a problem hiding this comment.
Very good point; updated.
BennettJames
force-pushed
the
preserve-grpc-port-value-from-crd
branch
from
4ee1c93 to
231c4bd
Compare
Yup, added a few more details to the description to make it clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix behavior for #710: ensure port is carried over for grpc route targets in virtual router.
When multiple listener support was added in #630, all targets were updated to handle crd -> sdk conversion except grpc ports. This adds matching support for grpc.
Testing:
Re-created the issue; patched the controller; deployed it; confirmed it resolved it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.