Use Virtual Service name for Virtual Router

[bcelenza]

Issue #, if available: #69

Description of changes:

Fix for the behavior that should default to the Virtual Service's name if the Virtual Router is not given an explicit name.

Testing:

Tested via make example. I noticed the app mesh object does not have unit tests. Is the appropriate place here?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[nckturner]

I noticed the app mesh object does not have unit tests.

Are you referring to the mesh struct here?

[bcelenza]

I noticed the app mesh object does not have unit tests.

Are you referring to the mesh struct here?

Yes, all structs defined in appmesh.go

[kiranmeduri]

Isn't this handled already @ https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/pkg/controller/virtualservice.go#L45. May be a bug in that logic there as https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/pkg/controller/virtualservice.go#L296 should handle it appropriately.

[bcelenza]

Isn't this handled already @ https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/pkg/controller/virtualservice.go#L45. May be a bug in that logic there as https://github.com/aws/aws-app-mesh-controller-for-k8s/blob/master/pkg/controller/virtualservice.go#L296 should handle it appropriately.

Wasn't aware of this logic. The logic to dynamically name appears duplicated. Is virtualservice.go the right place for it? Seems like it holds the higher level abstraction and is the right place.

In fact, this is probably why it's broken. The logic in appmesh.go is probably overwriting whatever value was set in virtualservice.go. Seeing if that's the case.