refactor(go): updates to RFC204 - golang bindings #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates RFC204 based on the latest developments for the
implementation thereof. In particular, the following elements have been
changed:
- Updates to *jsii interfaces* (aka: behavioral interfaces)
- Added a go struct for the concrete jsii proxy object
- Updates to *jsii structs* (aka: datatype interfaces)
- Replaced `Iface` suffix in go interface names with an `I` prefix
- Added *Approach 3* for handling jsii struct inheritance
- Updates to *jsii classes*
- Removed `Iface` suffix from go interfaces generated for classes
- Un-exported the go struct concrete type for the jsii proxy objects
- Removed unused properties from concrete types for jsii proxy objects
- Used mock jsii runtime calls to clarify activities that are proxied
to the `@jsii/kernel` process
RomainMuller
added
jsii
status/review
RomainMuller
commented
Feb 23, 2021
eladb
reviewed
Feb 23, 2021
eladb
reviewed
Feb 23, 2021
| } | ||
|
|
||
| // Optional - we can reduce boilerplate for conversion of BaseServiceProps -> BaseServiceOptions: | ||
| func (b BaseServiceProps) ToBaseServiceOptions() BaseServiceOptions { |
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Feb 23, 2021
As suggested in aws/aws-cdk-rfcs#292, using `_` to separate the constant name from the type name, and preserving the constant's casing results in an API that is slightly more readable, and less prone to namespace collisions.
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Feb 23, 2021
As proposed in aws/aws-cdk-rfcs#292 (this is *Approach 4*), stop rendering go interfaces to represent jsii structs, and instead only emit a plain go struct with the flattened list of fields (own + all super interfaces). Made the necessary code changes to de-serialize structs returned by-reference by the `@jsii/kernel` by eagerly fecthing all properties. Also, implemented the option to offer convenience conversion functions to easily create a parent type from a child type.
This was referenced Feb 23, 2021
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Feb 25, 2021
As suggested in aws/aws-cdk-rfcs#292, using `_` to separate the constant name from the type name, and preserving the constant's casing results in an API that is slightly more readable, and less prone to namespace collisions.
RomainMuller
added a commit
to aws/jsii
that referenced
this pull request
Feb 25, 2021
As proposed in aws/aws-cdk-rfcs#292 (this is *Approach 4*), stop rendering go interfaces to represent jsii structs, and instead only emit a plain go struct with the flattened list of fields (own + all super interfaces). Made the necessary code changes to de-serialize structs returned by-reference by the `@jsii/kernel` by eagerly fecthing all properties. Also, implemented the option to offer convenience conversion functions to easily create a parent type from a child type.
MrArnoldPalmer
approved these changes
Mar 4, 2021
This was referenced Mar 9, 2021
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates RFC204 based on the latest developments for the
implementation thereof. In particular, the following elements have been
changed:
Updates to jsii enums
_Updates to jsii interfaces (aka: behavioral interfaces)
Updates to jsii structs (aka: datatype interfaces)
Ifacesuffix in go interface names with anIprefixUpdates to jsii classes
Ifacesuffix from go interfaces generated for classesto the
@jsii/kernelprocess_to separate the type name & static method or property nameUpdates to properties:
structsapproaches 1, 2 and 3,removed the
Getprefix from getters (keepingSetprefix for setters), tomatch the recommendations of effective go
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license