Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump jsii-pacmak from 1.10.0 to 1.25.0 #180

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 17, 2021

Bumps jsii-pacmak from 1.10.0 to 1.25.0.

Release notes

Sourced from jsii-pacmak's releases.

v1.25.0

Features

Bug Fixes

v1.24.0

Features

  • go: support direct implementation of jsii interfaces (#2614) (9da3282), closes #2048

Bug Fixes

  • go: enums inside structs are not properly serialized (#2636) (19cbd25)
  • go: invalid generated code for classes a keyword name (#2641) (8668f13), closes #2637
  • go: malformed multiline docstrings in constructors (#2639) (72f25af), closes #2638

v1.23.0

Features

Bug Fixes

  • go: map values incorrectly handled though de/serialization (#2587) (0359928)
  • go-runtime: enums are not encoded/decoded correctly (#2585) (4731aeb), closes #2534
  • java: invalid code when multi-inheriting optional properties (#2591) (2399608), closes #22556
  • java: JsiiRuntime.ErrorStreamSink does not respond to being interrupted (#2540) (6e74bf9), closes #2533
  • jsii: excessive "exclude" in "tsconfig.json" (#1736) (ecffb9f)
  • pacmak: go 1.16 requires running "go mod download" explicitly (#2616) (1f8f022), closes #2615
  • pacmak: go local replace do not respect --outdir in some cases (#2584) (b9b9b4c)
  • pacmak: multiple go (and python) issues (#2622) (c2bd156), closes #2618 #2619 #2620 #2621

v1.22.0

Bug Fixes

... (truncated)

Changelog

Sourced from jsii-pacmak's changelog.

1.25.0 (2021-03-16)

Features

Bug Fixes

1.24.0 (2021-03-03)

Features

  • go: support direct implementation of jsii interfaces (#2614) (9da3282), closes #2048

Bug Fixes

  • go: enums inside structs are not properly serialized (#2636) (19cbd25)
  • go: invalid generated code for classes a keyword name (#2641) (8668f13), closes #2637
  • go: malformed multiline docstrings in constructors (#2639) (72f25af), closes #2638

1.23.0 (2021-03-01)

Features

Bug Fixes

  • go: map values incorrectly handled though de/serialization (#2587) (0359928)
  • go-runtime: enums are not encoded/decoded correctly (#2585) (4731aeb), closes #2534
  • java: invalid code when multi-inheriting optional properties (#2591) (2399608), closes #22556
  • java: JsiiRuntime.ErrorStreamSink does not respond to being interrupted (#2540) (6e74bf9), closes #2533
  • jsii: excessive "exclude" in "tsconfig.json" (#1736) (ecffb9f)
  • pacmak: go 1.16 requires running "go mod download" explicitly (#2616) (1f8f022), closes #2615

... (truncated)

Commits
  • 2dbe84d fix(go): invalid code when a module only has static methods [test only] (#2704)
  • 70bcd56 chore: npm-check-updates && yarn upgrade (#2696)
  • 52bd510 fix(go): duplicate conversion functions when parent structs have the same bas...
  • c9a36a6 fix(go): missing imports required by collection types (#2691)
  • daca06f fix(go): missing imports needed by base members (#2685)
  • 9562108 feat(go): packageName and versionSuffix (#2687)
  • 45b527c fix(go): nested types are not namespaced (#2650)
  • 7006e11 chore: npm-check-updates && yarn upgrade (#2674)
  • d6140ce chore(go): make Load call idempotent (#2645)
  • 1883362 chore: npm-check-updates && yarn upgrade (#2644)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 17, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 23, 2021

Superseded by #184.

@dependabot dependabot bot closed this Mar 23, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/jsii-pacmak-1.25.0 branch March 23, 2021 05:46
skorfmann pushed a commit that referenced this pull request Jun 1, 2021
*Issue #, if available:* N/A

*Description of changes:* Added a nextjs-ts project option which extends the typescript-app project class. Grouped some options together between the two nextjs project types, and implemented basic Next.js tsconfig project defaults so that both nextjs and nextjs-ts project types work out of the box.

----

Some notes:

I made a slight modification of TypeScriptConfig so that I can mark `tsconfig.json` as mutable, since the 'next build' command fails if it's immutable. The reason for this I believe is that the 'next' command tries to automatically change your tsconfig file if it sees that some options set incorrectly based on what Next.js's build system wants. I could send a feature request to the Next.js team to see if they can enable a CLI flag that skips this behavior, but for now this workaround makes the most sense.

There is a two-line file named `next-env.d.ts` that must be added to the root directory for TypeScript Next.js projects to successfully build. I included this in the PR, but it's worth suggesting that we should also eventually add an escape hatch so a user can omit or change the `next-env.d.ts` file if needed -- but I'm not sure what that mechanism should be, so I've left that unimplemented for now.

~Lastly, many Next.js projects don't have test directories from what I've seen, so I didn't include sample code for any. But this causes eslint to complain, and changing how the default eslint command behaves warrants a separate PR (see #182), and using `eslint: false` can lead to #180, so I ended up adding a small piece of cruft in the project constructor for now:~

```
this.addTestCommand('echo 0');
```

(I ended up overriding the default TypeScriptProject build command so this isn't an issue)

----

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment