Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): map values incorrectly handled though de/serialization #2587

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

RomainMuller
Copy link
Contributor

Map values were not handled in the de/serialization routines, resulting
in incorrect behavior.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Map values were not handled in the de/serialization routines, resulting
in incorrect behavior.
@RomainMuller RomainMuller added bug This issue is a bug. language/go Regarding GoLang bindings effort/small Small work item – less than a day of effort contribution/core This is a PR that came from AWS. labels Feb 17, 2021
@RomainMuller RomainMuller self-assigned this Feb 17, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Feb 17, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
  • Commit ID: c1b8e4f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0359928 into main Feb 17, 2021
@mergify mergify bot deleted the go-maps branch February 17, 2021 18:08
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Merging (with squash)...

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort language/go Regarding GoLang bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants