go 1.16 breaks go pacmak #2615

eladb · 2021-02-28T08:02:42Z

Starting go 1.16, go build will not update go.sum automatically and requires that users explicitly execute go mod download.

Since jsii/superchain now includes go 1.16 instead of 1.15, pacmak is now failing to create go bindings with the following error:

go: github.com/aws/jsii-runtime-go@v1.21.0: missing go.sum entry; to add it:
 	go mod download github.com/aws/jsii-runtime-go

To address, we need to run go mod download before we run go build.

The text was updated successfully, but these errors were encountered:

Starting go 1.16, `go build` does not download modules and updates go.sum automatically. To that end, we now execute this before we execute `go build` during pacmak. Additionally, set `GOSUMDB` to `off` in order to reduce the chance for eventual consistency issues when new modules are published. Fixes #2615

…2616) Starting go 1.16, `go build` does not download modules and updates go.sum automatically. To that end, we now execute this before we execute `go build` during pacmak. Additionally, set `GOSUMDB` to `off` in order to reduce the chance for eventual consistency issues when new modules are published. Fixes #2615

github-actions · 2021-02-28T12:31:57Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

eladb self-assigned this Feb 28, 2021

eladb removed their assignment Feb 28, 2021

eladb changed the title ~~Disable sumdb and proxy when building go bindings~~ go 1.16 breaks go pacmak Feb 28, 2021

eladb self-assigned this Feb 28, 2021

eladb mentioned this issue Feb 28, 2021

fix(pacmak): go 1.16 requires running "go mod download" explicitly #2616

Merged

eladb closed this as completed in #2616 Feb 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go 1.16 breaks go pacmak #2615

go 1.16 breaks go pacmak #2615

eladb commented Feb 28, 2021 •

edited

Loading

github-actions bot commented Feb 28, 2021

go 1.16 breaks go pacmak #2615

go 1.16 breaks go pacmak #2615

Comments

eladb commented Feb 28, 2021 • edited Loading

github-actions bot commented Feb 28, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

eladb commented Feb 28, 2021 •

edited

Loading