Skip to content

Commit

Permalink
feat(amplify-domain): Rename properties and adjusted optional. Code r…
Browse files Browse the repository at this point in the history
…eview suggestions
  • Loading branch information
janario committed Mar 4, 2021
1 parent c6407b5 commit 19ac74d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-amplify/lib/domain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ export interface DomainOptions {
*
* @default false
*/
readonly domainEnableAutoSubDomain: boolean;
readonly enableAutoSubdomain?: boolean;

/**
* Branches which should automatically create subdomains
*
* @default - all repository branches *, pr*
*/
readonly domainAutoSubDomainCreationPatterns?: string[];
readonly autoSubdomainCreationPatterns?: string[];
}

/**
Expand Down Expand Up @@ -120,8 +120,8 @@ export class Domain extends Resource {
appId: props.app.appId,
domainName,
subDomainSettings: Lazy.any({ produce: () => this.renderSubDomainSettings() }, { omitEmptyArray: true }),
enableAutoSubDomain: !!props.domainEnableAutoSubDomain,
autoSubDomainCreationPatterns: props.domainAutoSubDomainCreationPatterns,
enableAutoSubDomain: !!props.enableAutoSubdomain,
autoSubDomainCreationPatterns: props.autoSubdomainCreationPatterns,
});

this.arn = domain.attrArn;
Expand Down

0 comments on commit 19ac74d

Please sign in to comment.