Skip to content

Commit

Permalink
chore(pkglint): uncomment pkglint functionality (#28622)
Browse files Browse the repository at this point in the history
This was unintentionally commented out in a previous PR. Adding it back in.

This also includes the changes that pkglint would have picked up, if not commented out.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
TheRealAmazonKendra committed Jan 9, 2024
1 parent 65505f0 commit 3656a4c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/aws-cdk/THIRD_PARTY_LICENSES
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI

----------------

** cdk-from-cfn@0.91.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.91.0 | MIT OR Apache-2.0
** cdk-from-cfn@0.113.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.113.0 | MIT OR Apache-2.0

----------------

Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,4 @@
"publishConfig": {
"tag": "latest"
}
}
}
2 changes: 1 addition & 1 deletion tools/@aws-cdk/cdk-build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@
"ubergen": {
"exclude": true
}
}
}
4 changes: 1 addition & 3 deletions tools/@aws-cdk/pkglint/bin/pkglint.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env node
import * as path from 'path';
import * as yargs from 'yargs';
//import { findPackageJsons, ValidationRule } from '../lib';
import { findPackageJsons, ValidationRule } from '../lib';

const argv = yargs
.env('PKGLINT_')
Expand All @@ -19,7 +19,6 @@ if (typeof(directory) !== 'string') {
argv.directory = path.resolve(directory, process.cwd());

async function main(): Promise<void> {
/*
const ruleClasses = require('../lib/rules'); // eslint-disable-line @typescript-eslint/no-require-imports
const rules: ValidationRule[] = Object.keys(ruleClasses).map(key => new ruleClasses[key]()).filter(obj => obj instanceof ValidationRule);

Expand All @@ -37,7 +36,6 @@ async function main(): Promise<void> {
if (pkgs.some(p => p.hasReports)) {
throw new Error('Some package.json files had errors');
}
*/
}

main().catch((e) => {
Expand Down

0 comments on commit 3656a4c

Please sign in to comment.