Skip to content

Commit

Permalink
fix(appconfig): sourcedConfiguration doesn't use retrievalRole (#30733)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes #30609

### Reason for this change

To refactor the retrievalRole creation logic.



### Description of changes



### Description of how you validated changes

Unit tests:
1. configuration with retrievalRole undefined from bucket source should create a new role
2. configuration with retrievalRole defined should NOT create a new role and should use the passed role for the retrievalRoleArn
3. configuration with retrievalRole undefined from CodePipeline source should NOT create a new role

Integ test:
1. update the existing integ test to assert a use case where the retrievalRole is provided.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
pahud authored Jul 25, 2024
1 parent 742c52e commit 9d79c51
Show file tree
Hide file tree
Showing 9 changed files with 1,393 additions and 340 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 9d79c51

Please sign in to comment.