PR feedback

aws · Dec 27, 2020 · a004990 · a004990
1 parent 5310489
commit a004990
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 42 deletions.
diff --git a/packages/@aws-cdk/aws-elasticsearch/README.md b/packages/@aws-cdk/aws-elasticsearch/README.md
@@ -37,7 +37,7 @@ const devDomain = new es.Domain(this, 'Domain', {
 });
 ```
 
-Allowing upgrading an Amazon ES domain to a new version of Elasticsearch rather than replacing the entire domain resource.
+To perform version upgrades without replacing the entire domain, specify the `enableVersionUpgrade` property.
 
 ```ts
 import * as es from '@aws-cdk/aws-elasticsearch';

diff --git a/packages/@aws-cdk/aws-elasticsearch/lib/domain.ts b/packages/@aws-cdk/aws-elasticsearch/lib/domain.ts
@@ -522,6 +522,7 @@ export interface DomainProps {
    * To upgrade an Amazon ES domain to a new version of Elasticsearch rather than replacing the entire
    * domain resource, use the EnableVersionUpgrade update policy.
    *
+   * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html#cfn-attributes-updatepolicy-upgradeelasticsearchdomain
    * @default - false
    */
   readonly enableVersionUpgrade?: boolean;

diff --git a/packages/@aws-cdk/aws-elasticsearch/test/domain.test.ts b/packages/@aws-cdk/aws-elasticsearch/test/domain.test.ts
@@ -76,47 +76,6 @@ test('minimal example with resource props renders correctly', () => {
   });
 
   expect(stack).toHaveResource('AWS::Elasticsearch::Domain', {
-    Properties: {
-      CognitoOptions: {
-        Enabled: false,
-      },
-      DomainEndpointOptions: {
-        EnforceHTTPS: false,
-        TLSSecurityPolicy: 'Policy-Min-TLS-1-0-2019-07',
-      },
-      EBSOptions: {
-        EBSEnabled: true,
-        VolumeSize: 10,
-        VolumeType: 'gp2',
-      },
-      ElasticsearchClusterConfig: {
-        DedicatedMasterEnabled: false,
-        InstanceCount: 1,
-        InstanceType: 'r5.large.elasticsearch',
-        ZoneAwarenessEnabled: false,
-      },
-      ElasticsearchVersion: '7.1',
-      EncryptionAtRestOptions: {
-        Enabled: false,
-      },
-      LogPublishingOptions: {
-        AUDIT_LOGS: {
-          Enabled: false,
-        },
-        ES_APPLICATION_LOGS: {
-          Enabled: false,
-        },
-        SEARCH_SLOW_LOGS: {
-          Enabled: false,
-        },
-        INDEX_SLOW_LOGS: {
-          Enabled: false,
-        },
-      },
-      NodeToNodeEncryptionOptions: {
-        Enabled: false,
-      },
-    },
     UpdatePolicy: {
       EnableVersionUpgrade: true,
     },