Skip to content

Commit

Permalink
chore: do not dismiss changes requested by aws-cdk-automation (#22350)
Browse files Browse the repository at this point in the history
This will keep the pr-linter reviews from being dismissed until the checks pass and will quiet down the noise made by the  pr linter.
  • Loading branch information
TheRealAmazonKendra authored Oct 4, 2022
1 parent da3df7d commit aedee00
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ pull_request_rules:
- base=main
- -merged
- -closed
- changes-requested-reviews-by!=aws-cdk-automation
- name: if fails conventional commits
actions:
comment:
Expand Down
2 changes: 1 addition & 1 deletion tools/@aws-cdk/prlint/lint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export class PullRequestLinter {
* @returns Existing comment, if present
*/
private async findExistingComment(): Promise<Comment | undefined> {
const comments = await this.client.issues.listComments();
const comments = await this.client.issues.listComments(this.issueParams);
return comments.data.find((comment) => comment.user?.login === 'aws-cdk-automation' && comment.body?.startsWith('The pull request linter fails with the following errors:')) as Comment;
}

Expand Down

0 comments on commit aedee00

Please sign in to comment.