Add test case for short name

aws · Mar 6, 2021 · af9e731 · af9e731
1 parent f56c8c7
commit af9e731
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/@aws-cdk/aws-stepfunctions/lib/state-machine.ts b/packages/@aws-cdk/aws-stepfunctions/lib/state-machine.ts
@@ -434,8 +434,8 @@ export class StateMachine extends StateMachineBase {
     if (stateMachineName.length < 1 || stateMachineName.length > 80) {
       throw new Error(`State Machine name must be between 1 and 80 characters. Received: ${stateMachineName}`);
     }
-    if (!stateMachineName.match('^[0-9a-zA-Z\_\-]+$')) {
-      throw new Error(`State Machine name must match "^[0-9a-zA-Z\_\-]+$". Received: ${stateMachineName}`);
+    if (!stateMachineName.match('^[0-9a-zA-Z+!@._-]+$')) {
+      throw new Error(`State Machine name must match "^[0-9a-zA-Z+!@._-]+$". Received: ${stateMachineName}`);
     }
   }
 

diff --git a/packages/@aws-cdk/aws-stepfunctions/test/state-machine.test.ts b/packages/@aws-cdk/aws-stepfunctions/test/state-machine.test.ts
@@ -74,17 +74,22 @@ describe('State Machine', () => {
         stateMachineType: stepfunctions.StateMachineType.EXPRESS,
       });
     };
+    const tooShortName = '';
     const tooLongName = 'M'.repeat(81);
     const invalidCharactersName = '*';
 
     // THEN
+    expect(() => {
+      createStateMachine(tooShortName);
+    }).toThrow(`State Machine name must be between 1 and 80 characters. Received: ${tooShortName}`);
+
     expect(() => {
       createStateMachine(tooLongName);
     }).toThrow(`State Machine name must be between 1 and 80 characters. Received: ${tooLongName}`);
 
     expect(() => {
       createStateMachine(invalidCharactersName);
-    }).toThrow(`State Machine name must match "^[0-9a-zA-Z\_\-]+$". Received: ${invalidCharactersName}`);
+    }).toThrow(`State Machine name must match "^[0-9a-zA-Z+!@._-]+$". Received: ${invalidCharactersName}`);
   });
 
   test('log configuration', () => {