-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
### Issue # (if applicable) #29294 ### Reason for this change Currently cannot disable opensearch logging ### Description of changes If log parameters are explicitly set to false rather than undefined, it populates the logPublishingOptions with config to disable that logging ### Description of how you validated changes I added unit tests, although to be honest jest is giving me lots of trouble and I'm out of time for the day so I'll just create this pR and see what happens. Fingers crossed the PR test check is clean and I can pretend I know what I'm doing. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: GZ <yuanhaoz@amazon.com>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
{ | ||
"Resources": { | ||
"Domain66AC69E0": { | ||
"Type": "AWS::OpenSearchService::Domain", | ||
"Properties": { | ||
"ClusterConfig": { | ||
"DedicatedMasterEnabled": false, | ||
"InstanceCount": 1, | ||
"InstanceType": "r5.large.search", | ||
"MultiAZWithStandbyEnabled": false, | ||
"ZoneAwarenessEnabled": false | ||
}, | ||
"DomainEndpointOptions": { | ||
"EnforceHTTPS": false, | ||
"TLSSecurityPolicy": "Policy-Min-TLS-1-0-2019-07" | ||
}, | ||
"EBSOptions": { | ||
"EBSEnabled": true, | ||
"VolumeSize": 10, | ||
"VolumeType": "gp2" | ||
}, | ||
"EncryptionAtRestOptions": { | ||
"Enabled": false | ||
}, | ||
"EngineVersion": "OpenSearch_2.11", | ||
"LogPublishingOptions": { | ||
"SEARCH_SLOW_LOGS": { | ||
"Enabled": false | ||
}, | ||
"INDEX_SLOW_LOGS": { | ||
"Enabled": false | ||
}, | ||
"ES_APPLICATION_LOGS": { | ||
"Enabled": false | ||
}, | ||
"AUDIT_LOGS": { | ||
"Enabled": false | ||
} | ||
}, | ||
"NodeToNodeEncryptionOptions": { | ||
"Enabled": false | ||
} | ||
}, | ||
"UpdateReplacePolicy": "Delete", | ||
"DeletionPolicy": "Delete" | ||
} | ||
}, | ||
"Parameters": { | ||
"BootstrapVersion": { | ||
"Type": "AWS::SSM::Parameter::Value<String>", | ||
"Default": "/cdk-bootstrap/hnb659fds/version", | ||
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]" | ||
} | ||
}, | ||
"Rules": { | ||
"CheckBootstrapVersion": { | ||
"Assertions": [ | ||
{ | ||
"Assert": { | ||
"Fn::Not": [ | ||
{ | ||
"Fn::Contains": [ | ||
[ | ||
"1", | ||
"2", | ||
"3", | ||
"4", | ||
"5" | ||
], | ||
{ | ||
"Ref": "BootstrapVersion" | ||
} | ||
] | ||
} | ||
] | ||
}, | ||
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI." | ||
} | ||
] | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.