-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: make NPM dist tag explicit for all packages (#13109)
Currently, our NPM tag strategy is uniform across all packages. This _mostly_ works, but for V2 it makes sense for `aws-cdk-lib` to be published with a dist tag of 'latest' while still publishing all of the other libraries as 'next'. This change is the first supporting change to enable us to have different dist tags for different packages. * Introduces a new pkglint rule that enforces that each package.json has a publishConfig and tag. For v1, this defaults to 'latest'; for v2 it will default to 'next'. These are the correct values, except for `aws-cdk-lib`, which will need to be manually changed to `latest`. * Removes the disttag element from `release.json`. * Changing `check-api-compatibility` to use the dist tags from the individual `package.json` files, rather than from `release.json`. Files to look at (all others are package.json changes): * release.json * scripts/check-api-compatibility.sh * scripts/resolve-version-lib.js * scripts/script-tests/resolve-version.test.js * tools/pkglint/lib/rules.ts Once this is approved, and merged up to V2, the change to flip the aws-cdk-lib tag can be made. Finally, we will update our publishing infrastructure so these new tags are respected. related #13058 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
200 changed files
with
689 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,5 +92,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,5 +114,8 @@ | |
}, | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,5 +56,8 @@ | |
"maturity": "experimental", | ||
"cdk-build": { | ||
"jest": true | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,5 +96,8 @@ | |
"maturity": "deprecated", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,5 +93,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,5 +93,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,5 +92,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,5 +109,8 @@ | |
}, | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,5 +97,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,5 +103,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,5 +126,8 @@ | |
], | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,5 +93,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,5 +88,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,5 +91,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -190,5 +190,8 @@ | |
"maturity": "developer-preview", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,5 +92,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,5 +120,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,5 +94,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,5 +91,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,5 +114,8 @@ | |
"env": { | ||
"AWSLINT_BASE_CONSTRUCT": true | ||
} | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,5 +106,8 @@ | |
"env": { | ||
"AWSLINT_BASE_CONSTRUCT": true | ||
} | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,5 +92,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,5 +110,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,5 +106,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,5 +92,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,5 +91,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,5 +91,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,5 +102,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,5 +107,8 @@ | |
"maturity": "experimental", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,5 +100,8 @@ | |
"maturity": "stable", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,5 +160,8 @@ | |
}, | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,5 +115,8 @@ | |
"maturity": "stable", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,5 +102,8 @@ | |
"env": { | ||
"AWSLINT_BASE_CONSTRUCT": true | ||
} | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,5 +91,8 @@ | |
"maturity": "cfn-only", | ||
"awscdkio": { | ||
"announce": false | ||
}, | ||
"publishConfig": { | ||
"tag": "latest" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.