[aws-eks] Multiple object reference to Nested Stack causes Circular Dependency.

[ten-lac]

❓ General Issue

The Cluster interface creates circular dependency errors when multiple references to differing NestedStack child-objects. I'm not sure if this is an implementation error with Cluster or an inherent design flaw with NestedStack. It seems like a DAG would solve for this issue.

Tool Spec

• node@12
• cdk@1.6
• language=js

Error

Circular dependency between resources: [ControlPlaneEKSCreationRole58D1869A, ControlPlaneEKSKubectlReadyBarrier1C298D16, ControlPlaneEKSKubectlProviderSecurityGroup68FF96CB, ControlPlaneEKSCreationRoleDefaultPolicy5BFFD31E, NetworkNestedStackNetworkNestedStackResource0124E108, ControlPlaneEKSAwsAuthmanifestD1CB63E6, ControlPlaneEKSC6E4919A]

Code Snippet

const { App, Construct, Stack } = require('@aws-cdk/core');
const { Cluster } = require('@aws-cdk/aws-eks');
const { SecurityGroup, Vpc } = require('@aws-cdk/aws-ec2');

class MyApp extends App {
    constructor(scope, id, props) {
        super(scope, id, props);

        new MyStack(this, 'MyUnderlay');
    }
}

class MyStack extends Stack {
    constructor(scope, id, props) {
        super(scope, id, props);

        const { vpc, eksControlPlaneSecurityGroup } = new Network(this, 'MyNetwork');
        new ControlPlane(this, 'MyControlPlane', { vpc, eksControlPlaneSecurityGroup });
    }
}

class Network extends NestedStack {
    constructor(scope, id, props) {
        super(scope, id, props);

        const vpc = new Vpc(this, 'Vpc', {
            cidr: '20.1.0.0/16',
            enableDnsHostnames: true,
            enableDnsSupport: true,
            maxAzs: 99
        });

        const eksControlPlaneSecurityGroup = new SecurityGroup(this, 'EKSControlPlane', {
            securityGroupName: 'MyControlePlaneSG',
            vpc,
            allowAllOutbound: false
        });

        Object.assign(this, { vpc, eksControlPlaneSecurityGroup });
    }
}

class ControlPlane extends Construct {
    constructor(scope, id, props) {
        super(scope, id, props);

        const { vpc, eksControlPlaneSecurityGroup } = props;

        new Cluster(this, 'MyEKS', {
            clusterName: 'fake-cluster',
            version: KubernetesVersion.V1_17,
            vpc,
            securityGroup: eksControlPlaneSecurityGroup,  // removing this resolves the circular dep error observed
            defaultCapacity: 0
        });
    }
}

[iliapolo]

Related to #9536