Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Allow referencing Mappings in Conditions #10099

Closed
skinny85 opened this issue Sep 1, 2020 · 0 comments · Fixed by #10105
Closed

[cfn-include] Allow referencing Mappings in Conditions #10099

skinny85 opened this issue Sep 1, 2020 · 0 comments · Fixed by #10105
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. in-progress This issue is being actively worked on. p1
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

skinny85 commented Sep 1, 2020

As it turns out, this code is wrong; it's actually legal to reference a Mapping from a Condition.

The CFN docs on the topic state (emphasis mine):

(...) Within each condition, you can reference another condition, a parameter value, or a mapping.
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Sep 1, 2020
@skinny85 skinny85 added bug This issue is a bug. p1 labels Sep 1, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Sep 1, 2020
@skinny85
fix(cfn-include): allow Conditions to reference Mappings in their def…
935d242 
…initions

Fixes aws#10099
@skinny85 skinny85 mentioned this issue Sep 1, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 2, 2020
@mergify mergify bot closed this as completed in #10105 Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@skinny85
fix(cfn-include): allow Conditions to reference Mappings in their def…
aa2068f 
…initions (#10105)

Fixes #10099

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

fix(cfn-include): allow Conditions to reference Mappings in their definitions skinny85/aws-cdk
2 participants
@skinny85 @SomayaB