Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] aws-node-termination-handler bump to 0.9.5 #10277

Closed
pahud opened this issue Sep 10, 2020 · 0 comments · Fixed by #10278
Closed

[aws-eks] aws-node-termination-handler bump to 0.9.5 #10277

pahud opened this issue Sep 10, 2020 · 0 comments · Fixed by #10278
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pahud
Copy link
Contributor

pahud commented Sep 10, 2020

❓ General Issue

The latest helm chart version is 0.9.5

https://github.com/aws/eks-charts/blob/d453cba58689d880a0f9eae9fe96fac105b8b104/stable/aws-node-termination-handler/Chart.yaml#L4

And we were still in 0.7.3

this._spotInterruptHandler = this.addChart('spot-interrupt-handler', {
chart: 'aws-node-termination-handler',
version: '0.7.3',
repository: 'https://aws.github.io/eks-charts',
namespace: 'kube-system',
values: {
'nodeSelector.lifecycle': LifecycleLabel.SPOT,
},
});
}

I will create a PR for this.

The Question

Environment

  • CDK CLI Version:
  • Module Version:
  • Node.js Version:
  • OS:
  • Language (Version):

Other information

@pahud pahud added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 10, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Sep 10, 2020
@pahud pahud changed the title [aws-eks] aws-node-termination-handler bump to 0.9.5 [eks] aws-node-termination-handler bump to 0.9.5 Sep 10, 2020
@iliapolo iliapolo changed the title [eks] aws-node-termination-handler bump to 0.9.5 [aws-eks] aws-node-termination-handler bump to 0.9.5 Sep 10, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 in-progress This issue is being actively worked on. and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 10, 2020
@mergify mergify bot closed this as completed in #10278 Sep 11, 2020
mergify bot pushed a commit that referenced this issue Sep 11, 2020
Closes #10277

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants