Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecs-patterns] Add container name to QueueProcessingEc2Service #10517

Closed
1 of 2 tasks
caedmon-polly opened this issue Sep 24, 2020 · 1 comment · Fixed by #11093
Closed
1 of 2 tasks

[ecs-patterns] Add container name to QueueProcessingEc2Service #10517

caedmon-polly opened this issue Sep 24, 2020 · 1 comment · Fixed by #11093
Assignees
@uttarasridhar @MrArnoldPalmer
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@caedmon-polly
Copy link

Add an optional containerName to QueueProcessingEc2ServiceProps and use it when adding the container to the task definition, as is done by ApplicationLoadBalancedEc2Service.

Use Case

Sometimes it's nice to be able to name your containers.

Proposed Solution

Just do like ApplicationLoadBalancedEc2Service does and retain the current value of "QueueProcessingContainer" if containerName is not provided.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@caedmon-polly caedmon-polly added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 24, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Sep 25, 2020
@iRoachie iRoachie mentioned this issue Oct 25, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 26, 2020
@SoManyHs SoManyHs removed the needs-triage This issue or PR still needs to be triaged. label Nov 30, 2020
@MrArnoldPalmer MrArnoldPalmer added effort/medium Medium work item – several days of effort p2 labels Nov 30, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@iRoachie @flochaz
feat(ecs-patterns): containerName for QueueProcessingEc2Service
c6dd2a9 
resolves aws#10517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uttarasridhar uttarasridhar

@MrArnoldPalmer MrArnoldPalmer

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-patterns): add containerName to QueueProcessingEc2Service
5 participants
@uttarasridhar @MrArnoldPalmer @SomayaB @SoManyHs @caedmon-polly