feat(cli): add --no-lookups flag to disable context lookups
#11489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context lookups are supposed to be performed on developer desktops, and committed to `cdk.context.json`. If you don't, your CI build might try to perform a lookup and fail with an unclear error message about permissions, or worse: appear to work properly but leave you with a nondeterministic build. Introduce a CLI flag called `--no-lookups` that throws an appropriately descriptive error message if you forgot to perform context lookups before committing. This now also makes it possible to write an integration test for PR #11461.
|
|
rix0rrr
added
the
pr-linter/exempt-readme
|
Can you add this to the default synth action for CDK pipelines too? I think that should be set. |
I know. Want to land the feature first. |
Co-authored-by: Romain Marcadier <rmuller@amazon.com>
iliapolo
approved these changes
Nov 24, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context lookups are supposed to be performed on developer desktops, and
committed to
cdk.context.json. If you don't, your CI build might tryto perform a lookup and fail with an unclear error message about
permissions, or worse: appear to work properly but leave you with a
nondeterministic build.
Introduce a CLI flag called
--no-lookupsthat throws an appropriatelydescriptive error message if you forgot to perform context lookups
before committing.
This now also makes it possible to write an integration test for
PR #11461.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license