fix(core): missing context in Stages is not filled by CLI #11461
Conversation
Missing context in Stages was reported at the inner-assembly level. Since the CLI only inspects the top-level assembly for missing context, it would never detect this and not query for it. Propagate the missing context up to the top-level assembly. Fixes #9226.
|
|
|
Looks good, I would suggest adding an integ tests, the direct use of |
|
If we want an integtest I need to complicate this test, because this is not observable from the CLI behavior currently. |
|
I will take that in a different PR if that's okay with you |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Context lookups are supposed to be performed on developer desktops, and committed to `cdk.context.json`. If you don't, your CI build might try to perform a lookup and fail with an unclear error message about permissions, or worse: appear to work properly but leave you with a nondeterministic build. Introduce a CLI flag called `--no-lookups` that throws an appropriately descriptive error message if you forgot to perform context lookups before committing. This now also makes it possible to write an integration test for PR #11461.
Context lookups are supposed to be performed on developer desktops, and committed to `cdk.context.json`. If you don't, your CI build might try to perform a lookup and fail with an unclear error message about permissions, or worse: appear to work properly but leave you with a nondeterministic build. Introduce a CLI flag called `--no-lookups` that throws an appropriately descriptive error message if you forgot to perform context lookups before committing. This now also makes it possible to write an integration test for PR #11461. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Missing context in Stages was reported at the inner-assembly
level. Since the CLI only inspects the top-level assembly for
missing context, it would never detect this and not query for it.
Propagate the missing context up to the top-level assembly.
Fixes #9226.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license