Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(s3): support S3 bucket keys #11828

Closed
2 tasks
hoegertn opened this issue Dec 2, 2020 · 3 comments · Fixed by #12376
Closed
2 tasks

(s3): support S3 bucket keys #11828

hoegertn opened this issue Dec 2, 2020 · 3 comments · Fixed by #12376
Assignees
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@hoegertn
Copy link
Contributor

hoegertn commented Dec 2, 2020

Add property to S3 Bucket to configure bucket-level keys.

https://docs.aws.amazon.com/AmazonS3/latest/dev/configuring-bucket-key.html#enable-bucket-key-cloudformation

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@hoegertn hoegertn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 2, 2020
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Dec 2, 2020
@iliapolo iliapolo added effort/medium Medium work item – several days of effort p1 needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. effort/medium Medium work item – several days of effort p1 labels Dec 2, 2020
@iliapolo
Copy link
Contributor

iliapolo commented Dec 2, 2020

@hoegertn Can you please elaborate exactly what you'd like to configure? ideally with a theoretical API?

We already have support for passing an encryption key and the encryption type:

readonly encryption?: BucketEncryption;

readonly encryptionKey?: kms.IKey;

Are you referring to the BucketEnabledKey we currently don't support and the ability to configure multiple rules?

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 2, 2020
@hoegertn
Copy link
Contributor Author

hoegertn commented Dec 2, 2020

Exactly, this is meant as a tracking ticket for the newly released BucketEnabledKEy field to enable bucket-level keys for S3

@iliapolo iliapolo added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Dec 2, 2020
@mergify mergify bot closed this as completed in #12376 Jan 20, 2021
mergify bot pushed a commit that referenced this issue Jan 20, 2021
Ok. I am just taking a swing at this, bc I think it is straight-forward. Please let me know if you had something different in mind @hoegertn .

closes #11828
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this issue Jan 24, 2021
Ok. I am just taking a swing at this, bc I think it is straight-forward. Please let me know if you had something different in mind @hoegertn .

closes aws#11828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants