Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(network-firewall): unable to deploy the CfnFirewallPolicy construct #11974

Closed
SomayaB opened this issue Dec 10, 2020 · 2 comments · Fixed by #12204
Closed

(network-firewall): unable to deploy the CfnFirewallPolicy construct #11974

SomayaB opened this issue Dec 10, 2020 · 2 comments · Fixed by #12204
Assignees
@skinny85
Labels
@aws-cdk/aws-networkfirewall Related to AWS Network Firewall bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@SomayaB
Copy link
Contributor

SomayaB commented Dec 10, 2020

I am unable to deploy the CfnFirewallPolicy construct included in the latest update. TypeScript sees the construct as valid, but CloudFormation raises the following validation errors:

Properties validation failed for resource firewallpolicy with message:
#/Tags: expected type: JSONArray, found: JSONObject
#/FirewallPolicy/StatelessDefaultActions: expected type: JSONArray, found: JSONObject
#/FirewallPolicy/StatelessFragmentDefaultActions: expected type: JSONArray, found: JSONObject

On further inspection of the CloudFormation documentation, I believe there is an inconsistency in the spec for this resource. The specification seems to define AWS::NetworkFirewall::FirewallPolicy.StatelessActions as a nested object, but the top-level example shows it as a simple list. I believe the CDK is synthesizing the nested object form, while CloudFormation is actually expecting the list form.

Originally posted by @bf-sodle in #11675 (comment)
@SomayaB SomayaB added @aws-cdk/aws-networkfirewall Related to AWS Network Firewall bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 10, 2020
@SomayaB
Copy link
Contributor Author

SomayaB commented Dec 10, 2020

@skinny85 confirmed the bug and is working on a fix.

@SomayaB SomayaB mentioned this issue Dec 10, 2020
Closed
2 tasks
@skinny85 skinny85 mentioned this issue Dec 16, 2020
Closed
@skinny85 skinny85 mentioned this issue Dec 29, 2020
Merged
@mergify mergify bot closed this as completed in #12204 Jan 5, 2021
mergify bot pushed a commit that referenced this issue Jan 5, 2021
@aws-cdk-automation
feat(cfnspec): cloudformation spec v22.0.0 (#12204)
a5be2e9 
Fixes #12170
Fixes #11974
Fixes #12114
Fixes #12028
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@aws-cdk-automation @flochaz
feat(cfnspec): cloudformation spec v22.0.0 (aws#12204)
593421e 
Fixes aws#12170
Fixes aws#11974
Fixes aws#12114
Fixes aws#12028
@swsunny swsunny mentioned this issue Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-networkfirewall Related to AWS Network Firewall bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cfnspec): cloudformation spec v22.0.0 aws/aws-cdk
2 participants
@skinny85 @SomayaB