Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cloudfront): provide stack name for EdgeLambda #12136

Closed
bcraft opened this issue Dec 17, 2020 · 3 comments · Fixed by #12163
Closed

(cloudfront): provide stack name for EdgeLambda #12136

bcraft opened this issue Dec 17, 2020 · 3 comments · Fixed by #12163
Assignees
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@bcraft
Copy link

bcraft commented Dec 17, 2020

Please would it be possible to add a parameter into the new edge lambda construct to specify the stack name which is created in us-east-1.

Use Case

Different applications hosted in the same accounts who require independent lambda functions in us-east-1, currently the stack name is fixed at edge-lambda-stack-{REGION}, it would be useful to be able to override this.

This is a 🚀 Feature Request

@bcraft bcraft added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 17, 2020
@SomayaB SomayaB changed the title Cloufront experiment EdgeLambda (cloufront): experiment EdgeLambda Dec 17, 2020
@SomayaB SomayaB changed the title (cloufront): experiment EdgeLambda (cloudfront): experiment EdgeLambda Dec 17, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 17, 2020
@njlynch
Copy link
Contributor

njlynch commented Dec 17, 2020

Sure, this is a reasonable request, and a fairly easy one to achieve. We'd just need to add a prop to EdgeFunctionProps and then use the value here:

const edgeStackId = `edge-lambda-stack-${region}`;

@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 17, 2020
@njlynch njlynch changed the title (cloudfront): experiment EdgeLambda (cloudfront): provide stack name for EdgeLambda Dec 17, 2020
@saudkhanzada
Copy link
Contributor

@njlynch Can I take this up?

@mergify mergify bot closed this as completed in #12163 Jan 4, 2021
mergify bot pushed a commit that referenced this issue Jan 4, 2021
Closes #12136

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
Closes aws#12136

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants