Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CDK, KMS Keys): cannot set "pending_window_in_days" for aws_cdk.aws_kms.Key #12218

Closed
2 tasks
CorneVerhoogAegon opened this issue Dec 24, 2020 · 1 comment · Fixed by #12224
Closed
2 tasks
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@CorneVerhoogAegon
Copy link

In aws_cdk.aws_kms.CfnKey there's a parameter called "pending_window_in_days" where you can set the amount of days before kms key deletion. However aws_cdk_aws_kms.Key does not have anything like this or an alternative to change the days before deletion below a month.

Use Case

Currently we run integration tests everyday which create a lot of stacks per day and delete them afterwards, however kms keys keep floating around for too long, causing us to reach the kms key limit, and also the costs for the kms keys for the entire month are a lot more than what we would have paid for if it deleted itself after 7 days.

Proposed Solution

Add a similiar feature to aws_cdk,aws_kms.Key to set the amount of days before a kms key gets deleted when the stack gets deleted.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@CorneVerhoogAegon CorneVerhoogAegon added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 24, 2020
@mergify mergify bot closed this as completed in #12224 Jan 4, 2021
mergify bot pushed a commit that referenced this issue Jan 4, 2021
Closes [#12218](#12218)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
Closes [aws#12218](aws#12218)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant