Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-kms): support waiting period #12224

Merged
merged 10 commits into from
Jan 4, 2021

Conversation

hassanazharkhan
Copy link
Contributor

@hassanazharkhan hassanazharkhan commented Dec 25, 2020

Closes #12218


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 25, 2020

@github-actions github-actions bot added the @aws-cdk/aws-kms Related to AWS Key Management label Dec 25, 2020
packages/@aws-cdk/aws-kms/lib/key.ts Show resolved Hide resolved
packages/@aws-cdk/aws-kms/lib/key.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed NetaNir’s stale review December 29, 2020 18:26

Pull request has been modified.

@hassanazharkhan
Copy link
Contributor Author

@NetaNir PR now ready for another look

@NetaNir NetaNir changed the title feat(aws-kms): Added an option in Key construct to specifiy the numbe… feat(aws-kms): support waiting period Jan 3, 2021
packages/@aws-cdk/aws-kms/lib/key.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-kms/README.md Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0f221e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f451bd into aws:master Jan 4, 2021
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
Closes [aws#12218](aws#12218)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-kms Related to AWS Key Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(CDK, KMS Keys): cannot set "pending_window_in_days" for aws_cdk.aws_kms.Key
4 participants