Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(elbv2): redirect listeners are always open #12766

Assignees
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@MatthewMooreZA
Copy link
Contributor

When calling loadBalancer.addRedirect() the listener is always created as open. This results in the creation of an ingress rule from all sources on the inbound port.

Use Case

The use of ingress rules from all sources is not always desirable and it would be nice to have the option to turn this off.

Proposed Solution

Add an optional open property to ApplicationLoadBalancerRedirectConfig and pass this through when creating the listener. Default open to true to ensure backwards compatibility.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@MatthewMooreZA MatthewMooreZA added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Jan 29, 2021
MatthewMooreZA added a commit to MatthewMooreZA/aws-cdk that referenced this issue Jan 29, 2021
@mergify mergify bot closed this as completed in #12768 Feb 25, 2021
mergify bot pushed a commit that referenced this issue Feb 25, 2021
)

This change adds the ability to specify whether you'd like a redirect listener to be open or not.  
If you don't want the open ingress rule created you'll now be able to do the following:

```ts
loadBalancer.addRedirect({ open: false });
```

fixes #12766


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment