Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-apigateway): Change default DomainName default SecurityPolicy to TLS_1_2 #13306

Closed
1 task
jonnekaunisto opened this issue Feb 27, 2021 · 3 comments
Closed
1 task

(aws-apigateway): Change default DomainName default SecurityPolicy to TLS_1_2 #13306

jonnekaunisto opened this issue Feb 27, 2021 · 3 comments
Assignees
@nija-at
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@jonnekaunisto
Copy link
Contributor

Change the default DomainName SecurityPolicy to TLS1.2, since major browsers are dropping support for TLS1.0, so it is not a sensible default anymore

  • [ x ] 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@jonnekaunisto jonnekaunisto added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 27, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Feb 27, 2021
@robertd robertd mentioned this issue Feb 27, 2021
Merged
@jonnekaunisto
Copy link
Contributor Author

According to #13309 this cannot be done since it'd be a breaking change

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rrhodes
Copy link
Contributor

rrhodes commented Mar 29, 2021

Disappointed to see this issue closed. IMO this seems like a reasonable request. If there is any argument to made for limited exceptions to the "no breaking changes in stable packages" rule then it would be nice to see TLS 1.2 set as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonnekaunisto @rrhodes @nija-at