chore(apigateway): cleanup DomainName TLS docstring and tests

[robertd]

Cleanup of apigateway module (docs & tests).

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[nija-at]

Thanks for submitting this change @robertd.

I believe the default that is documented is the default that CloudFormation is applying.
I've not personally verified this, and if that's inaccurate, we need to update the doc string.

@aws-cdk/aws-apigateway is a stable module and we don't accept breaking changes to this module. Unfortunately, the default will have to remain what it already is.

Pull request has been modified.

[robertd]

@nija-at I've removed portions of setting the TLS by default. In the CloudFormation docs SecurityPolicy is an optional parameter. I'll try creating a vanilla api gateway and see what it defaults to. In the meantime... I'm changing this PR to be more of a chore/cleanup one.

I'll provide an update soon.

[robertd]

@nija-at It seems like CloudFormation is setting this to TLS_1_0 by default. I'll update the docstring to reflect this.

[robertd]

@nija-at I've repurposed this PR as a chore/cleanup. I'm not really sure where to submit a PR to update cloudformation docs.

Also, I still think this PR addresses #13306 to a certain extent since we cannot set default value due to module being stable at this point.

Thanks!

[nija-at]

The rest of the code clean up looks good. See 2 comments below.

[nija-at]

Could you also update the PR title and description to match your new updates?

[robertd]

Could you also update the PR title and description to match your new updates?

Updated the title... forgot to hit Save button :)

Pull request has been modified.

[robertd]

@nija-at reverts have been made...

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: d5c71e4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).