feat(ec2): ESP and AH IPsec protocols for Security Groups #13471
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
rix0rrr
added
the
pr-linter/exempt-readme
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| @@ -9,6 +9,8 @@ export enum Protocol { | |||
| UDP = 'udp', | |||
| ICMP = 'icmp', | |||
| ICMPV6 = '58', | |||
| ESP = 'esp', | |||
| AH = 'ah', | |||
There was a problem hiding this comment.
This needs to be ESP = ‘50’ and AH = ‘51’
There was a problem hiding this comment.
Also there are many other protocols that need to be added to this enum
https://en.wikipedia.org/wiki/List_of_IP_protocol_numbers
| return new Port({ | ||
| protocol: Protocol.AH, | ||
| fromPort: 51, | ||
| toPort: 51, |
There was a problem hiding this comment.
fromPort and toPort both need to be unset for both protocols
First contribution. I've gone through the checklist and think i've managed to hit all the requirements. I'd like to contribute more and I'm taking it slow so let me know how I can improve my PRs
Closes #13403
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license