feat(ec2): support all Security Group protocols

[rectalogic]

Protocol numbers must be used for all but a handful of protocols.

Issue #13403 was closed with an incorrect PR merge #13471. According to CFN docs only a handful of protocol names are supported, protocol numbers must be used for the rest.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-security-group-rule-1.html#cfn-ec2-security-group-rule-ipprotocol

This adds all protocol numbers to the enum.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[hollanddd]

Great. This is the info I'm looking for. I think that esp and ah functions need to be there in order to surface the underlying properties although i acknowledge that their implementation is incorrect.

[rectalogic]

Great. This is the info I'm looking for. I think that esp and ah functions need to be there in order to surface the underlying properties although i acknowledge that their implementation is incorrect.

But are you going to make functions for every protocol? It seems unnecessary, users can just construct a Port as needed for all these obscure protocols:

new Port({
  protocol: Protocol.ESP,
  stringRepresentation: 'ESP',
});

[hollanddd]

here are two commits to clean up the cruft from my original pr if you want to swipe them for your PR. First one removes the tests there were added and the second adds the protocols to the list of ignored docs in package.json

[rix0rrr]

Build fails

Pull request has been modified.

[rectalogic]

I don't have access to the failed logs so I don't know why build is failing
https://us-east-1.console.aws.amazon.com/codebuild/home?region=us-east-1#/builds/AutoBuildProject89A8053A-LhjRyN9kxr8o:821211eb-de18-478d-be74-5f56c25b7516/view/new

[NetaNir]

@rectalogic the comment above includes the a link to the logs.

[rix0rrr]

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: f6e2794
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[rectalogic]

It's failing because I removed the APIs added by the previous botched merge

API elements with incompatible changes:
err  - METHOD @aws-cdk/aws-ec2.Port.ah: has been removed [removed:@aws-cdk/aws-ec2.Port.ah]
err  - METHOD @aws-cdk/aws-ec2.Port.esp: has been removed [removed:@aws-cdk/aws-ec2.Port.esp]

[hollanddd]

It's addressed in #13593. Sorry for the confusion

[rix0rrr]

I think this PR is no longer necessary, right?

[rectalogic]

right