Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(elasticsearch): support V7_10 #14502

Closed
prashanttct07 opened this issue May 3, 2021 · 4 comments · Fixed by #14320
Closed

(elasticsearch): support V7_10 #14502

prashanttct07 opened this issue May 3, 2021 · 4 comments · Fixed by #14320
Assignees
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@prashanttct07
Copy link
Contributor

AWS supports the creation of ES domains with version 7.10 CDK only supports 7.9,
aws_elasticsearch.ElasticsearchVersion.V7_9 is max we can get as of Today (CDK 1.101)

Probably by simply adding enumerator ElasticsearchVersion.V7_10 to the aws_elasticsearch module, people would be able to get the benefits of the newer ES version.

Use Case

To support Amazon ES version in one of the AWS sample amazon-elasticsearch-service-monitor

Proposed Solution

add enum V7_10

  • [May not be] 👋 I may be able to implement this feature request
  • [Not Sure] ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@prashanttct07 prashanttct07 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label May 3, 2021
@iliapolo iliapolo changed the title ElasticSearch: support V7_10 (elasticsearch): support V7_10 May 3, 2021
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels May 3, 2021
@iliapolo
Copy link
Contributor

iliapolo commented May 3, 2021

As a workaround, one can use:

new es.Domain(this, 'Domain', {
  version: es.ElasticsearchVersion.of('7.10'),
});

@prashanttct07
Copy link
Contributor Author

Thanks @iliapolo.
Workaround seems to work fine. Do you want me to close this request or should I keep it open as it's still good to update the CDK code too.

@iliapolo
Copy link
Contributor

iliapolo commented May 3, 2021

We can keep it open.

@mergify mergify bot closed this as completed in #14320 May 3, 2021
mergify bot pushed a commit that referenced this issue May 3, 2021
Resolves #14502 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented May 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
Resolves aws#14502 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Resolves aws#14502 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants