Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-neptune): Include 1.0.5.0 in AWS Neptune Engine Version #16388

Closed
rakcy opened this issue Sep 6, 2021 · 2 comments · Fixed by #16394
Closed

(aws-neptune): Include 1.0.5.0 in AWS Neptune Engine Version #16388

rakcy opened this issue Sep 6, 2021 · 2 comments · Fixed by #16394
Assignees
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@rakcy
Copy link

rakcy commented Sep 6, 2021

1.0.5.0 seems to be missing from the list of AWS Neptune Engine Version

Use Case

We need this to be able to use the latest AWS Neptune Engine Version

Proposed Solution

export class EngineVersion {
/**
* Neptune engine version 1.0.1.0
*/
public static readonly V1_0_1_0 = new EngineVersion('1.0.1.0');
/**
* Neptune engine version 1.0.1.1
*/
public static readonly V1_0_1_1 = new EngineVersion('1.0.1.1');
/**
* Neptune engine version 1.0.1.2
*/
public static readonly V1_0_1_2 = new EngineVersion('1.0.1.2');
/**
* Neptune engine version 1.0.2.1
*/
public static readonly V1_0_2_1 = new EngineVersion('1.0.2.1');
/**
* Neptune engine version 1.0.2.2
*/
public static readonly V1_0_2_2 = new EngineVersion('1.0.2.2');
/**
* Neptune engine version 1.0.3.0
*/
public static readonly V1_0_3_0 = new EngineVersion('1.0.3.0');
/**
* Neptune engine version 1.0.4.0
*/
public static readonly V1_0_4_0 = new EngineVersion('1.0.4.0');
/**
* Neptune engine version 1.0.4.1
*/
public static readonly V1_0_4_1 = new EngineVersion('1.0.4.1');
/**
* Constructor for specifying a custom engine version
* @param version the engine version of Neptune
*/
public constructor(public readonly version: string) {}
}


This is a 🚀 Feature Request

@rakcy rakcy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 6, 2021
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Sep 6, 2021
@jumic
Copy link
Contributor

jumic commented Sep 6, 2021

I created a PR for the new version.

It is already possible to use the new version if you specify the version number as a string:

new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.T3_MEDIUM,
  engineVersion: new neptune.EngineVersion('1.0.5.0'),
});

@njlynch njlynch added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 10, 2021
@njlynch njlynch assigned jumic and unassigned njlynch Sep 10, 2021
@mergify mergify bot closed this as completed in #16394 Sep 10, 2021
mergify bot pushed a commit that referenced this issue Sep 10, 2021
Add AWS Neptune engine versions 1.0.5.0.
https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases-1.0.5.0.html

Closes #16388.

Deployment successfully testet:
```ts
new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.T3_MEDIUM,
  engineVersion: neptune.EngineVersion.V1_0_5_0,
});
```


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants