Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDKv2GA]: Remove stability banners for Cfn constructs from alpha modules READMEs #17038

Closed
madeline-k opened this issue Oct 18, 2021 · 1 comment · Fixed by #17327
Closed

[CDKv2GA]: Remove stability banners for Cfn constructs from alpha modules READMEs #17038

madeline-k opened this issue Oct 18, 2021 · 1 comment · Fixed by #17327
Assignees
@otaviomacedo
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Milestone
[GA] CDK V2

Comments

@madeline-k
Copy link
Contributor

madeline-k commented Oct 18, 2021 •
edited
Loading

We need to remove the stability banner for the Cfn constructs when generating the alpha modules, since the alpha modules do not contain these constructs.

The alpha modules are generated in: https://github.com/aws/aws-cdk/blob/master/tools/@aws-cdk/individual-pkg-gen/transform-packages.ts
@madeline-k madeline-k added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2021
@madeline-k madeline-k added this to the [GA] CDK V2 milestone Oct 18, 2021
@madeline-k madeline-k removed the needs-triage This issue or PR still needs to be triaged. label Oct 18, 2021
@madeline-k madeline-k self-assigned this Oct 18, 2021
@madeline-k madeline-k added the effort/small Small work item – less than a day of effort label Oct 18, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 18, 2021
@njlynch njlynch added the p2 label Oct 26, 2021
@otaviomacedo otaviomacedo self-assigned this Nov 3, 2021
@otaviomacedo otaviomacedo mentioned this issue Nov 4, 2021
Merged
@mergify mergify bot closed this as completed in #17327 Nov 4, 2021
mergify bot pushed a commit that referenced this issue Nov 4, 2021
@otaviomacedo
chore: stripping stability banners for Cfn constructs on alpha modules (
bc00427 
#17327)

Alpha modules don't have Cfn constructs, so it doesn't make sense to have a stability banner for them on the README.

Fixes #17038.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@otaviomacedo @TikiTDO
chore: stripping stability banners for Cfn constructs on alpha modules (
1e840a0 
aws#17327)

Alpha modules don't have Cfn constructs, so it doesn't make sense to have a stability banner for them on the README.

Fixes aws#17038.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otaviomacedo otaviomacedo

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
[GA] CDK V2
Development

Successfully merging a pull request may close this issue.

chore: stripping stability banners for Cfn constructs on alpha modules aws/aws-cdk
4 participants
@otaviomacedo @rix0rrr @njlynch @madeline-k