Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(lambda): Specifying insightsVersion triggers warning to make lazy #17133

Closed
evantrimboli opened this issue Oct 24, 2021 · 2 comments · Fixed by #17665
Closed

(lambda): Specifying insightsVersion triggers warning to make lazy #17133

evantrimboli opened this issue Oct 24, 2021 · 2 comments · Fixed by #17665
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@evantrimboli
Copy link

What is the problem?

When specifying the insightsVersion property on a lambda function, the following warning is generated:

[Info at /my-app/LambdaInsightsVersions10980] Consider making this CfnMapping a lazy mapping by providing `lazy: true`: either no findInMap was called or every findInMap could be immediately resolved without using Fn::FindInMap

This only started occurring after adding the insightsVersion property to the lambda.

Reproduction Steps

Create a lambda function:

new NodejsFunction('my-fn', {
    runtime: Runtime.NODEJS_14_X,
      ...baseFnOptions,
      vpc,
      functionName: 'foo'
      handler: 'runFoo',
      insightsVersion: LambdaInsightsVersion.VERSION_1_0_98_0
});

What did you expect to happen?

No warning

What actually happened?

A warning.

CDK CLI Version

1.111.0

Framework Version

No response

Node.js Version

14.15.4

OS

Windows

Language

Typescript

Language Version

Typescript 4.3.5

Other information

No response

@evantrimboli evantrimboli added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 24, 2021
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Oct 24, 2021
@nija-at
Copy link
Contributor

nija-at commented Oct 28, 2021

Thanks for filing this issue @evantrimboli.

At this time, it's safe to ignore this warning.

@nija-at nija-at added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2021
@nija-at nija-at removed their assignment Nov 25, 2021
@mergify mergify bot closed this as completed in #17665 Dec 13, 2021
mergify bot pushed a commit that referenced this issue Dec 13, 2021
Adding builtin support for the new ARM64 CloudWatch insights Lambda
layers which were [announced](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-cloudwatch-lambda-insights-functions-graviton2/)
yesterday.

also fixes #17133

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
Adding builtin support for the new ARM64 CloudWatch insights Lambda
layers which were [announced](https://aws.amazon.com/about-aws/whats-new/2021/11/amazon-cloudwatch-lambda-insights-functions-graviton2/)
yesterday.

also fixes aws#17133

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants