Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(iot): TopicRule action for SNS in AWS IoT #17700

Closed
2 tasks
yamatatsu opened this issue Nov 25, 2021 · 1 comment · Fixed by #18839
Closed
2 tasks

(iot): TopicRule action for SNS in AWS IoT #17700

yamatatsu opened this issue Nov 25, 2021 · 1 comment · Fixed by #18839
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@yamatatsu
Copy link
Contributor

Description

The CDK has no support to publish an SNS Topic via AWS IoT Rule.

Use Case

Adding the action that publishes an SNS Topic to AWS IoT topic rule.

Proposed Solution

Implementing action class.

Probably, following PRs help coding.

Other information

Follofing documentation will be help.

It will be good first issue for learning implement feature in CDK!

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@yamatatsu yamatatsu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 25, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Nov 25, 2021
@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 feature/service-integration Add functionality to an L2 construct to enable easier integration with another service and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2021
@AdamVD AdamVD mentioned this issue Feb 5, 2022
Merged
@mergify mergify bot closed this as completed in #18839 Feb 9, 2022
mergify bot pushed a commit that referenced this issue Feb 9, 2022
@AdamVD
feat(iot-actions): add SNS publish action (#18839)
3a39f6b 
First-time contributor 👋 

fixes #17700 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

moelasmar pushed a commit to moelasmar/aws-cdk that referenced this issue Feb 15, 2022
@AdamVD @moelasmar
feat(iot-actions): add SNS publish action (aws#18839)
dddad8a 
First-time contributor 👋 

fixes aws#17700 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@AdamVD @TikiTDO
feat(iot-actions): add SNS publish action (aws#18839)
c8298c6 
First-time contributor 👋 

fixes aws#17700 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iot Related to AWS IoT effort/small Small work item – less than a day of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iot-actions): add SNS publish action AdamVD/aws-cdk
3 participants
@skinny85 @yamatatsu @peterwoodworth