-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-ecs-patterns): add support for Fargate ephemeral storage #18105
Labels
@aws-cdk/aws-ecs-patterns
Related to ecs-patterns library
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Comments
tapichu
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Dec 20, 2021
github-actions
bot
added
the
@aws-cdk/aws-ecs-patterns
Related to ecs-patterns library
label
Dec 20, 2021
tapichu
added a commit
to tapichu/aws-cdk
that referenced
this issue
Dec 20, 2021
Fargate supports a new ephemeral storage option, to request up to 200 GiB of task storage. Support for it was added to aws-ecs but not to aws-ecs-patterns. This change adds support for ephemeral storage, so the following patterns can take advantage of it: * Application load balanced fargate service * Application multiple target groups fargate service * Network load balanced fargate service * Network multiple target groups fargate service * Queue processing fargate service * Scheduled fargate task Closes aws#18105 Signed-off-by: Eduardo Lopez <252504+tapichu@users.noreply.github.com>
tapichu
added a commit
to tapichu/aws-cdk
that referenced
this issue
Dec 20, 2021
Fargate supports a new ephemeral storage option, to request up to 200 GiB of task storage. Support for it was added to aws-ecs but not to aws-ecs-patterns. This change adds support for ephemeral storage, so the following patterns can take advantage of it: * Application load balanced fargate service * Application multiple target groups fargate service * Network load balanced fargate service * Network multiple target groups fargate service * Queue processing fargate service * Scheduled fargate task Closes aws#18105 Signed-off-by: Eduardo Lopez <252504+tapichu@users.noreply.github.com>
madeline-k
added
p2
effort/small
Small work item – less than a day of effort
good first issue
Related to contributions. See CONTRIBUTING.md
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Dec 21, 2021
Is there any update on this issue? This is blocking my team's adoption of this construct |
This was referenced Feb 26, 2024
mergify bot
pushed a commit
that referenced
this issue
Mar 1, 2024
…rvices (#29275) ### Issue # (if applicable) Closes #18105. ### Reason for this change In April 2021, Fargate added support for [requesting additional ephemeral storage](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/fargate-task-storage.html#fargate-task-storage-pv14). Support for this feature has [been added](f1bf935#diff-dcfbc499b4d3c10afcd4e63ad0e4ecc54df2464e45af67f1fdae69d3fa2d43a0) to the aws-ecs package, but is still not supported by the aws-ecs-patterns package. ### Description of changes This code change adds an optional field `ephemeralStorageGiB` in `packages/aws-cdk-lib/aws-ecs-patterns/lib/base/fargate-service-base.ts`, after other fields like `cpu` and `memoryLimitMiB`. ### Description of how you validated changes Added unit tests and new integration tests. Created a simple CDK application with the new constructs, and verified that it synthesized and deployed correctly. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns
Related to ecs-patterns library
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Description
In April 2021, Fargate added support for requesting additional ephemeral storage.
Support for this feature has been added to the
aws-ecs
package, but is still not supported by theaws-ecs-patterns
package.Use Case
aws-ecs-patterns
supports the following patterns:Users of these patterns are currently unable to request additional ephemeral storage beyond the 20 GiB provided by default. By adding support for this new feature, users will be able to request up to 200 GiB of ephemeral storage for their Fargate services.
Proposed Solution
The proposal is to follow the precedent set by the
aws-ecs
package:All the patterns in
aws-ecs-patterns
use under the hoodaws-ecs
'sFargateTaskDefinition
. Therefore, the proposed implementation will use the same naming convention, and forward the value toecs.FargateTaskDefinition
. All validation and setting of default values will be left toaws-ecs
.This is what a
FargateScheduledTask
would look like:Other information
aws-ecs-patterns
is inconsistent in how it exposes some configuration options.FargateScheduledTask
puts the cpu/memory options insideFargateTaskImageOptions
:By contrast, all the other patterns (ALB, NLB, Queue) set these values outside of the task image options, as top-level properties:
For backwards-compatibility, this proposal will not attempt to address this inconsistency between the patterns, and will follow the existing convention set by each pattern.
Acknowledge
The text was updated successfully, but these errors were encountered: