Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ecs): InstanceDrainHook is still using EOL python runtime #20085

Closed
2 tasks
mrudelle opened this issue Apr 26, 2022 · 3 comments · Fixed by #19988 or #20647
Closed
2 tasks

(ecs): InstanceDrainHook is still using EOL python runtime #20085

mrudelle opened this issue Apr 26, 2022 · 3 comments · Fixed by #19988 or #20647
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@mrudelle
Copy link

Describe the feature

From AWS:

We are ending support for Python 3.6 in AWS Lambda. This follows Python 3.6 End-Of-Life (EOL) reached on December 23, 2021 [1].

As described in the Lambda runtime support policy [2], end of support for language runtimes in Lambda happens in two stages. Starting July 18, 2022, Lambda will no longer apply security patches and other updates to the Python 3.6 runtime used by Lambda functions, and functions using Python 3.6 will no longer be eligible for technical support. In addition, you will no longer be able to create new Lambda functions using the Python 3.6 runtime. Starting August 17, 2022, you will no longer be able to update existing functions using the Python 3.6 runtime.

Construct InstanceDrainHook (used ECS cluster construcs) is using this runtime:

aws-cdk/packages/@aws-cdk/aws-ecs/lib/drain-hook/instance-drain-hook.ts

Line 70 in 3d192a9

runtime: lambda.Runtime.PYTHON_3_6,

Use Case

We would like to deploy ECS services via CDK and not use deprecated python runtimes

Proposed Solution

Switch this construct's lambda to python3.9

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.21.1

Environment details (OS name and version, etc.)

N/A
@mrudelle mrudelle added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2022
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Apr 26, 2022
@kaizencc kaizencc changed the title InstanceDrainHook is still using EOL python runtime (ecs): InstanceDrainHook is still using EOL python runtime Apr 26, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Apr 26, 2022
@kaizencc kaizencc added bug This issue is a bug. p1 effort/small Small work item – less than a day of effort and removed @aws-cdk/aws-lambda Related to AWS Lambda feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2022
@jackm-ts
Copy link

+1 we also got this notification and would love a new version of the aws-cdk/aws-ecs package with this python version bumped

@kaizencc kaizencc mentioned this issue May 4, 2022
Merged
@jackm-ts
Copy link

We just got another email from AWS on this, any idea when the above PR might be merged/released?

@peterwoodworth peterwoodworth mentioned this issue May 19, 2022
Closed
mergify bot pushed a commit that referenced this issue Jun 7, 2022
@rix0rrr
fix(lambda): deprecate Python3.6 (#19988)
9602229 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
RomainMuller pushed a commit that referenced this issue Jun 7, 2022
@rix0rrr @RomainMuller
fix(lambda): deprecate Python3.6 (#19988)
8014703 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

# Conflicts:
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/aws-cdk-eks-cluster-alb-controller-test.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/awscdkeksclusteralbcontrollertestawscdkawseksKubectlProviderA1AC28D1.nested.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/cdk.out
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/integ.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-lambda/test/function.test.ts
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/aws-stepfunctions-tasks-emr-containers-start-job-run-integ-test.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/awsstepfunctionstasksemrcontainersstartjobrunintegtestawscdkawseksKubectlProviderC26A0FC7.nested.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/cdk.out
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/integ.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/tree.json
RomainMuller pushed a commit that referenced this issue Jun 7, 2022
@rix0rrr @RomainMuller
fix(lambda): deprecate Python3.6 (#19988)
b78df0a 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

# Conflicts:
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/aws-cdk-eks-cluster-alb-controller-test.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/awscdkeksclusteralbcontrollertestawscdkawseksKubectlProviderA1AC28D1.nested.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-lambda/test/function.test.ts
#	packages/@aws-cdk/aws-lambda/test/runtime.inlinecode.integ.snapshot/aws-cdk-lambda-runtime-inlinecode.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/aws-stepfunctions-tasks-emr-containers-start-job-run-integ-test.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/awsstepfunctionstasksemrcontainersstartjobrunintegtestawscdkawseksKubectlProviderC26A0FC7.nested.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/lambda/invoke-function.integ.snapshot/integ.json
#	packages/@aws-cdk/lambda-layer-awscli/test/awscli-layer.integ.snapshot/lambda-layer-awscli-integ-stack.template.json
@RomainMuller RomainMuller mentioned this issue Jun 7, 2022
Merged
RomainMuller pushed a commit that referenced this issue Jun 7, 2022
@rix0rrr @RomainMuller
fix(lambda): deprecate Python3.6 (#19988)
404af24 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

# Conflicts:
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/aws-cdk-eks-cluster-alb-controller-test.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/awscdkeksclusteralbcontrollertestawscdkawseksKubectlProviderA1AC28D1.nested.template.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-eks/test/alb-controller.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-lambda/test/function.test.ts
#	packages/@aws-cdk/aws-lambda/test/runtime.inlinecode.integ.snapshot/aws-cdk-lambda-runtime-inlinecode.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/aws-stepfunctions-tasks-emr-containers-start-job-run-integ-test.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/awsstepfunctionstasksemrcontainersstartjobrunintegtestawscdkawseksKubectlProviderC26A0FC7.nested.template.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/manifest.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/emrcontainers/start-job-run.integ.snapshot/tree.json
#	packages/@aws-cdk/aws-stepfunctions-tasks/test/lambda/invoke-function.integ.snapshot/integ.json
#	packages/@aws-cdk/lambda-layer-awscli/test/awscli-layer.integ.snapshot/lambda-layer-awscli-integ-stack.template.json
@mergify mergify bot closed this as completed in #20647 Jun 7, 2022
mergify bot pushed a commit that referenced this issue Jun 7, 2022
@RomainMuller
fix(lambda): deprecate Python3.6 (#19988) (#20647)
c8f5cd2 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes #20085.
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Jun 14, 2022
Closed
Merged
mergify bot added a commit that referenced this issue Jun 14, 2022
@mergify
chore(release): 1.160.0 (#20730)
de59b89 
See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/1.160.0/CHANGELOG.md)

-------------------------

## [1.160.0](v1.159.0...v1.160.0) (2022-06-14)


### ⚠  Removal of Node 12

- Starting with this release, Node 12 is no longer supported and customers should upgrade to Node 14, 16, or 18.

### Features

* **cfnspec:** cloudformation spec v75.0.0 ([#20615](#20615)) ([0a13e09](0a13e09))


### Bug Fixes

* **lambda:** deprecate Python3.6 ([#19988](#19988)) ([9602229](9602229)), closes [#20085](#20085)


### Miscellaneous Chores

* **deps:** npm-check-updates && yarn upgrade  ([#20684](#20684)) ([e661fe9](e661fe9))
daschaa pushed a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
@RomainMuller @daschaa
fix(lambda): deprecate Python3.6 (aws#19988) (aws#20647)
ce42413 
Move all automatic Custom Resources to the newest Python version, update
integ tests, add a note to the Lambda Runtime that it shouldn't be used
anymore.

Change all Python3.6 -> Python 3.9.

Fixes aws#20085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
4 participants
@mrudelle @kaizencc @jackm-ts @madeline-k