ec2: changes to enum values breaks deprecated enums for v1 #21131
Comments
c0state
added
bug
github-actions
bot
added
the
@aws-cdk/aws-ec2
peterwoodworth
added
wontfix
peterwoodworth
removed
the
wontfix
|
I believe this is going to be just a v1 bug - which is in maintenance mode. CDK v2 only features the non deprecated version of each enum, and we've made changes recently to make sure this works and is not confusing in all languages. We've renamed the value of each deprecated enum to have a prefix of Is there anything preventing you from changing values or migrating to v2? |
peterwoodworth
added
the
response-requested
peterwoodworth
changed the title
No good reason, just wondering. This also happens on v2 though. In addition, |
github-actions
bot
removed
the
response-requested
corymhall
changed the title
corymhall
added
management/tracking
corymhall
changed the title
corymhall
removed
management/tracking
|
Created a new pinned issue to track the p0 #21138 |
In #19320, we changed the values of deprecated enums to include a `Deprecated_` prefix. This also meant we had to do some gymnastics in the code to change usages of the value to a switch case. However, there were also places in the code that do enum comparison, which uses the enum value. Those comparison points need to also explicitly consider the equivalent deprecated enums. Fixes #21131, Fixes #21138 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
In #19320, we changed the values of deprecated enums to include a `Deprecated_` prefix. This also meant we had to do some gymnastics in the code to change usages of the value to a switch case. However, there were also places in the code that do enum comparison, which uses the enum value. Those comparison points need to also explicitly consider the equivalent deprecated enums. Fixes #21131, Fixes #21138 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 0b5123a)
|
Describe the bug
Starting with CDK version
1.162.0, if I previously had deployed a VPC with subnet of typeec2.SubnetType.PRIVATE(I understand that it's deprecated now), then simply updating to CDK1.162.0and running a deploy ends up causing the CDK to try to delete a bunch of NAT gateways, elastic IPs, and routes. If I change the type toec2.SubnetType.PRIVATE_WITH_NAT, it doesn't do this.I thought
ec2.SubnetType.PRIVATEandec2.SubnetType.PRIVATE_WITH_NATwere equivalent?There were a bunch of changes to the consts to clarify private, public and/or isolated subnets recently. I'm assuming something there is causing this.
Expected Behavior
Updating the CDK to 1.162.0 without changes to our stack configuration shouldn't remove existing NAT gateways, elastic IPs or routes from a VPC
Current Behavior
Updating the CDK with a VPC that has a subnet with a type of
PRIVATEcauses the diff to show a deletion of various NAT gateways, elastic IPs and routes.Reproduction Steps
Deploy a VPC with a subnet of type
PRIVATEwith CDK versionv1.161.0.Then simply update to
v1.162.0and run a diff--it will inexplicably try to delete various NAT gateways, elastic IPs and routes.Possible Solution
It looks like changing the type to
PRIVATE_WITH_NATfixes this but as stated above, I thoughtPRIVATEandPRIVATE_WITH_NATwere the same.Additional Information/Context
No response
CDK CLI Version
1.162.0
Framework Version
1.162.0
Node.js Version
v16.16.0
OS
macOS
Language
Typescript
Language Version
4.7.4
Other information
No response
The text was updated successfully, but these errors were encountered: