Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sns: Support setting of delivery status logging with the CDK #21971

Closed
2 tasks
DanielBauman88 opened this issue Sep 8, 2022 · 6 comments · Fixed by #28433
Closed
2 tasks

aws-sns: Support setting of delivery status logging with the CDK #21971

DanielBauman88 opened this issue Sep 8, 2022 · 6 comments · Fixed by #28433
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@DanielBauman88
Copy link

Describe the feature

This does not appear to be supported right now.

This does not currently seem to be supported by cloudformation but the same custom resource workaround used for log retention policy could unblock cdk support.

Use Case

This lack of functionality is particularly frustrating because security hub notifies about this issue but then customers have no way to easily comply in an automated fashion using cdk/cfn (the best practice tools for deploying infra).

https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-standards-fsbp-controls.html#fsbp-sns-2

Proposed Solution

Best option: Get cloudformation support and natively support setting this property on the topic
Second best option: Support this via a custom resource built into the cdk

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

any

Environment details (OS name and version, etc.)

any
@DanielBauman88 DanielBauman88 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2022
@github-actions github-actions bot added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Sep 8, 2022
@kaizencc kaizencc added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2022
@kaizencc
Copy link
Contributor

kaizencc commented Sep 9, 2022

Thanks for opening the feature request, @DanielBauman88! I agree with both proposed solutions. Using a custom resource would work, but I'm wary of introducing more custom resources to the CDK without being sure of their necessity. Lets wait and see if this issue gets more support and/or wait and see if CloudFormation will come through.

@kaizencc kaizencc added the needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. label Sep 9, 2022
@DanielBauman88
Copy link
Author

Here is a CloudFormation issue tracking the same: aws-cloudformation/cloudformation-coverage-roadmap#66

As this is required to comply with security-hub I think it is a pretty strong case for its necessity.

@kaizencc
Copy link
Contributor

Great! As soon as this is in CloudFormation I'm happy to support this in the CDK.

@kaizencc kaizencc removed their assignment Sep 27, 2022
@ZackKanter
Copy link
Contributor

Great! As soon as this is in CloudFormation I'm happy to support this in the CDK.

Now that this has CloudFormation support, it would be great to get this into CDK.

@tam0ri
Copy link
Contributor

tam0ri commented Dec 19, 2023

I'm working on it. Will submit PR later.

@tam0ri tam0ri mentioned this issue Dec 20, 2023
Merged
@mergify mergify bot closed this as completed in #28433 Dec 21, 2023
mergify bot pushed a commit that referenced this issue Dec 21, 2023
@tam0ri
feat(sns): delivery status logging configuration (#28433)
36bb696 
Recently Amazon SNS supports configuring delivery status logging with AWS CloudFormation.
https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-sns-configuring-delivery-status-logging-aws-cloudformation/?nc1=h_ls

This is also configurable via L1 CfnTopic construct.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_sns.CfnTopic.html

This PR introduces the feature to add delivery status logging configuration via L2 Topic construct.
Closes #21971

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@tam0ri @paulhcsun
feat(sns): delivery status logging configuration (aws#28433)
15e2ae9 
Recently Amazon SNS supports configuring delivery status logging with AWS CloudFormation.
https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-sns-configuring-delivery-status-logging-aws-cloudformation/?nc1=h_ls

This is also configurable via L1 CfnTopic construct.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_sns.CfnTopic.html

This PR introduces the feature to add delivery status logging configuration via L2 Topic construct.
Closes aws#21971

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sns): delivery status logging configuration tam0ri/aws-cdk
4 participants
@DanielBauman88 @ZackKanter @tam0ri @kaizencc