-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub source authentication works differently #2199
Comments
Perhaps it's only needed for the webhook...? @rix0rrr , can you try the above with |
I did this with webhook: true, fwiw |
And did it work? (were builds triggered by just pushing to the repository?) |
Yep. Looks like we've been thinking about this all wrong. Before connecting to repos, you're supposed to call ImportSourceCredentials for GitHub, using a token you get from doing an OAuth browser flow or a Personal Access Token. CodeBuild will store this token somewhere on their end. After that, you create a project and set auth.type=OAUTH, which will lead them to use the token they have stored server side. Until CloudFormation grows support for |
That means the action is to get rid of |
Auth field should not be set since it's ignored by CodeBuild https://docs.aws.amazon.com/codebuild/latest/APIReference/API_ProjectSource.html#CodeBuild-Type-ProjectSource-auth BREAKING CHANGE: customers who use GitHub, GitHubEnterprise or Bitbucket as source will need to remove the oauthToken field as it's no longer available Fixes aws#2199
Auth field should not be set since it's ignored by CodeBuild https://docs.aws.amazon.com/codebuild/latest/APIReference/API_ProjectSource.html#CodeBuild-Type-ProjectSource-auth BREAKING CHANGE: customers who use GitHub, GitHubEnterprise or Bitbucket as source will need to remove the oauthToken field as it's no longer available Fixes #2199
In our GitHubSource,
oauthToken
is required, but it doesn't actually do anything.You're supposed to authenticate the whole of CodeBuild against all of your repositories using OAuth in the console. Afterwards, you don't have to pass a token value, you just have to set auth-type to "OAUTH" and it'll work.
For reference, the following seems to work fine:
@skinny85, any clue?
The text was updated successfully, but these errors were encountered: