Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-eks): instanceType is deprecated, use instanceTypes instead #22547

Closed
bora-7 opened this issue Oct 18, 2022 · 5 comments · Fixed by #22590
Closed

(aws-eks): instanceType is deprecated, use instanceTypes instead #22547

bora-7 opened this issue Oct 18, 2022 · 5 comments · Fixed by #22590
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@bora-7
Copy link
Contributor

bora-7 commented Oct 18, 2022 •
edited
Loading

Describe the bug

There are some integ tests in aws-eks using the deprecated instanceType instead of the instanceTypes and yarn test throws a lot of warnings.

Expected Behavior

No more warnings for deprecated 'instanceType' properties from 'yarn test'

Current Behavior

There are warning signs since instanceType is now deprecated and instanceTypes should be used instead

Reproduction Steps

yarn test on aws-eks

Possible Solution

Change mentions of instanceType to 'instanceTypes'

CDK CLI Version

2.44.0

Node.js Version

v16.13.2

OS

MacOS

Language

Typescript
@bora-7 bora-7 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2022
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Oct 18, 2022
@MrSyn88
Copy link
Contributor

MrSyn88 commented Oct 18, 2022

Working on it

@peterwoodworth
Copy link
Contributor

What's the bug you're describing exactly? We deprecated this prop two years ago, so you should only be able to use instanceType in v1, and if you do so in v1 you should see this warning message because we want to throw warnings when properties are deprecated.

@peterwoodworth peterwoodworth added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2022
@peterwoodworth peterwoodworth added bug This issue is a bug. p2 effort/small Small work item – less than a day of effort and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Oct 18, 2022
@bora-7
Copy link
Contributor Author

bora-7 commented Oct 18, 2022

I've updated the description now to make it more clear

@peterwoodworth
Copy link
Contributor

Thanks @bora-7! Let us know once you've submitted a PR

@MrSyn88 MrSyn88 mentioned this issue Oct 20, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #22590 Oct 20, 2022
mergify bot pushed a commit that referenced this issue Oct 20, 2022
@MrSyn88
chore(aws-eks): changed instanceType to instanceTypes in addNodegroup…
03210be 
…Capacity functions (#22590)

fixes #22547 

---
 
Since `instanceType` is deprecated, I changed it to `instanceTypes` in all the `addNodegroupCapacity` functions

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mrgrain pushed a commit to mrgrain/aws-cdk that referenced this issue Oct 24, 2022
@MrSyn88 @mrgrain
chore(aws-eks): changed instanceType to instanceTypes in addNodegroup…
7ccd39b 
…Capacity functions (aws#22590)

fixes aws#22547 

---
 
Since `instanceType` is deprecated, I changed it to `instanceTypes` in all the `addNodegroupCapacity` functions

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
4 participants
@otaviomacedo @peterwoodworth @MrSyn88 @bora-7