Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(apprunner): (apprunner observability configuration support) #22985

Closed
2 tasks
Brass-Perkins opened this issue Nov 18, 2022 · 4 comments · Fixed by #30359, codu-code/codu#969 or rwlxxvii/containers#185 · May be fixed by NOUIY/aws-solutions-constructs#112 or gitafolabi/kreuzlaker#2
Labels
@aws-cdk/aws-apprunner Related to the apprunner package feature-request A feature should be added or improved. p3

Comments

@Brass-Perkins
Copy link

Describe the feature

Support for Apprunner's Observability Configuration support: https://aws.amazon.com/about-aws/whats-new/2022/04/aws-app-runner-x-ray-support/

Use Case

Support for configuration of Observability

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.51.0

Environment details (OS name and version, etc.)

N/A

@Brass-Perkins Brass-Perkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 18, 2022
@github-actions github-actions bot added the @aws-cdk/aws-apprunner Related to the apprunner package label Nov 18, 2022
@pahud pahud added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Nov 18, 2022
@pahud
Copy link
Contributor

pahud commented Nov 18, 2022

Thanks for your report. It seems like we need to add the ServiceObservabilityConfiguration L2 prop support to the Apprunner Service construct. Before we add the L2 prop support, you can use ServiceObservabilityConfigurationProperty to define the ServiceObservabilityConfiguration and add use escape hatches to override the property like:

const service = new apprunner.Service(...);

const serviceObservabilityConfigurationProperty: CfnService.ServiceObservabilityConfigurationProperty = {
  observabilityEnabled: false,
  observabilityConfigurationArn: 'observabilityConfigurationArn',
};

(service.node.defaultChild as CfnService).addPropertyOverride('ObservabilityConfiguration', serviceObservabilityConfigurationProperty);

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@pahud pahud added p2 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Nov 18, 2022
@corymhall corymhall removed their assignment Apr 15, 2024
@mazyu36
Copy link
Contributor

mazyu36 commented May 28, 2024

I'm working on it.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment