eks: missing package.json in the integ test #25178
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Comments
pahud
added
bug
pahud
changed the title
3 tasks
mergify bot
pushed a commit
that referenced
this issue
Apr 21, 2023
…Cloud regions (#25215) Reopening this PR because #25170 was closed by accident. As ECR Public is not available in China regions and GovCloud, `AmazonElasticContainerRegistryPublicReadOnly` IAM managed policy would not be available in those affected regions and should not be attached to the role. This PR implements a CfnCondition to determine if ECR public is available based on `Aws.Partition` of the deploying region and conditionally attach `AmazonElasticContainerRegistryPublicReadOnly` to the kubectl-provider handler role. This PR has been tested in the following regions: - [x] *cn-north-1 - [x] *cn-northwest-1 - [x] us-east-1 * I can confirm the role is created correctly in cn regions but due to - #24358 - #24696 The cluster and nodegroup are still failing to create in CN. Closes #24743 #24808 #25178
mergify bot
pushed a commit
that referenced
this issue
May 5, 2023
This PR fixes 2 integ tests from aws-eks. - `integ.eks-helm-assets` is failing because 2 helm charts are trying to install with the same release name and this is failing with race condition. This PR replaces one of them with another helm chart from ACK to avoid that and ensures the integ test will succeed. - `integ.eks-service-account-sdk-call` is missing `package.json` and `sdk-call.js` as described in #25178 and `docker build` is failing due to missing files. We restored them from [v2.72.1](https://github.com/aws/aws-cdk/tree/v2.72.1/packages/%40aws-cdk/aws-eks/test/sdk-call-integ-test-docker-app/app) with minor update on the test. Now both integ tests can successfully run with no error. Closes #25438 #25178 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
closed by #25448 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
package.jsonis missing in aws-eks/test/sdk-call-integ-test-docker-app/app/ and the DockerImageAssets bundling from the integ testing is failing.aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/sdk-call-integ-test-docker-app/app/Dockerfile
Line 8 in 8ca4c09
The
package.jsonwas still existing back to v2.72.1 but for some reason it was removed. The integ test will fail if this file is missing.Expected Behavior
The integ test(sdk-call-integ-test-docker-app) should succeed.
Current Behavior
The integ test(sdk-call-integ-test-docker-app) fails due to missing
package.jsonand can't bundle the docker image assets.Reproduction Steps
yarn integ test/sdk-call-integ-test-docker-app.js --forceto run the integ test.Possible Solution
Add the missing
package.jsonback.Additional Information/Context
No response
CDK CLI Version
2.72.1
Framework Version
No response
Node.js Version
v18.15.0
OS
mac os x
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: